Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct punctuation for ingest processors help text #75695

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Correct punctuation for ingest processors help text #75695

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d932ad
Correct punctuation for ingest pipelines help text
jrodewig Aug 21, 2020
25a14d2
Merge branch 'master' into ui__fix-ingest-proc-punct
elasticmachine Aug 24, 2020
a5cc823
Add missing period
jrodewig Aug 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...editor/components/manage_processor_form/processors/common_fields/ignore_missing_field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const fieldsConfig: FieldsConfig = {
helpText: (
<FormattedMessage
id="xpack.ingestPipelines.pipelineEditor.commonFields.ignoreMissingFieldHelpText"
defaultMessage="Ignore documents with a missing {field}"
defaultMessage="Ignore documents with a missing {field}."
values={{
field: <EuiCode>{'field'}</EuiCode>,
}}
Expand Down
6 changes: 3 additions & 3 deletions ...ponents/pipeline_processors_editor/components/manage_processor_form/processors/enrich.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export const Enrich: FunctionComponent = () => {
helpText: (
<FormattedMessage
id="xpack.ingestPipelines.pipelineEditor.enrichForm.policyNameHelpText"
defaultMessage="Name of the {enrichPolicyLink}"
defaultMessage="Name of the {enrichPolicyLink}."
values={{
enrichPolicyLink: (
<EuiLink external target="_blank" href={esDocUrl + '/ingest-enriching-data.html'}>
Expand All @@ -182,7 +182,7 @@ export const Enrich: FunctionComponent = () => {
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.enrichForm.targetFieldHelpText',
{
defaultMessage: 'Field used to contain enrich data',
defaultMessage: 'Field used to contain enrich data.',
}
)}
validations={[targetFieldValidator]}
Expand All @@ -202,7 +202,7 @@ export const Enrich: FunctionComponent = () => {
helpText: (
<FormattedMessage
id="xpack.ingestPipelines.pipelineEditor.enrichForm.shapeRelationFieldHelpText"
defaultMessage="Operator used to match the geo-shape of incoming documents to enrich documents. Only used for {geoMatchPolicyLink}"
defaultMessage="Operator used to match the geo-shape of incoming documents to enrich documents. Only used for {geoMatchPolicyLink}."
values={{
geoMatchPolicyLink: (
<EuiLink
Expand Down
2 changes: 1 addition & 1 deletion ...omponents/pipeline_processors_editor/components/manage_processor_form/processors/fail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const fieldsConfig: FieldsConfig = {
defaultMessage: 'Message',
}),
helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.failForm.messageHelpText', {
defaultMessage: 'Error message returned by the processor',
defaultMessage: 'Error message returned by the processor.',
}),
validations: [
{
Expand Down
4 changes: 2 additions & 2 deletions ...onents/pipeline_processors_editor/components/manage_processor_form/processors/foreach.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const fieldsConfig: FieldsConfig = {
defaultMessage: 'Processor',
}),
helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.foreachForm.processorHelpText', {
defaultMessage: 'Ingest processor to run on each array value',
defaultMessage: 'Ingest processor to run on each array value.',
}),
validations: [
{
Expand Down Expand Up @@ -56,7 +56,7 @@ export const Foreach: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.failForm.fieldNameHelpText',
{ defaultMessage: 'Field containing array values' }
{ defaultMessage: 'Field containing array values.' }
)}
/>

Expand Down
4 changes: 2 additions & 2 deletions ...mponents/pipeline_processors_editor/components/manage_processor_form/processors/geoip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,15 @@ export const GeoIP: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.geoIPForm.fieldNameHelpText',
{ defaultMessage: 'Field containing an IP address for the geographical lookup' }
{ defaultMessage: 'Field containing an IP address for the geographical lookup.' }
)}
/>

<TargetField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.geoIPForm.targetFieldHelpText',
{
defaultMessage: 'Field used to contain geo data properties',
defaultMessage: 'Field used to contain geo data properties.',
}
)}
/>
Expand Down
4 changes: 2 additions & 2 deletions ...omponents/pipeline_processors_editor/components/manage_processor_form/processors/grok.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ const fieldsConfig: FieldsConfig = {
helpText: i18n.translate(
'xpack.ingestPipelines.pipelineEditor.grokForm.traceMatchFieldHelpText',
{
defaultMessage: 'Add metadata about the matching expression to the document',
defaultMessage: 'Add metadata about the matching expression to the document.',
}
),
},
Expand All @@ -99,7 +99,7 @@ export const Grok: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.grokForm.fieldNameHelpText',
{ defaultMessage: 'Field to search for matches' }
{ defaultMessage: 'Field to search for matches.' }
)}
/>

Expand Down
6 changes: 3 additions & 3 deletions ...omponents/pipeline_processors_editor/components/manage_processor_form/processors/gsub.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const fieldsConfig: FieldsConfig = {
}),
deserializer: String,
helpText: i18n.translate('xpack.ingestPipelines.pipelineEditor.gsubForm.patternFieldHelpText', {
defaultMessage: 'Regular expression used to match substrings in the field',
defaultMessage: 'Regular expression used to match substrings in the field.',
}),
validations: [
{
Expand All @@ -49,7 +49,7 @@ const fieldsConfig: FieldsConfig = {
}),
helpText: i18n.translate(
'xpack.ingestPipelines.pipelineEditor.gsubForm.replacementFieldHelpText',
{ defaultMessage: 'Replacement text for matches' }
{ defaultMessage: 'Replacement text for matches.' }
),
validations: [
{
Expand All @@ -69,7 +69,7 @@ export const Gsub: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.gsubForm.fieldNameHelpText',
{ defaultMessage: 'Field to search for matches' }
{ defaultMessage: 'Field to search for matches.' }
)}
/>

Expand Down
2 changes: 1 addition & 1 deletion ...nts/pipeline_processors_editor/components/manage_processor_form/processors/html_strip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const HtmlStrip: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.htmlStripForm.fieldNameHelpText',
{ defaultMessage: 'Field to remove HTML tags from' }
{ defaultMessage: 'Field to remove HTML tags from.' }
)}
/>

Expand Down
2 changes: 1 addition & 1 deletion ...ents/pipeline_processors_editor/components/manage_processor_form/processors/inference.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const fieldsConfig: FieldsConfig = {
helpText: i18n.translate(
'xpack.ingestPipelines.pipelineEditor.inferenceForm.modelIDFieldHelpText',
{
defaultMessage: 'ID of the model to infer against',
defaultMessage: 'ID of the model to infer against.',
}
),
validations: [
Expand Down
4 changes: 2 additions & 2 deletions ...omponents/pipeline_processors_editor/components/manage_processor_form/processors/join.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const fieldsConfig: FieldsConfig = {
helpText: i18n.translate(
'xpack.ingestPipelines.pipelineEditor.joinForm.separatorFieldHelpText',
{
defaultMessage: 'Separator character',
defaultMessage: 'Separator character.',
}
),
validations: [
Expand All @@ -49,7 +49,7 @@ export const Join: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.joinForm.fieldNameHelpText',
{ defaultMessage: 'Field containing array values to join' }
{ defaultMessage: 'Field containing array values to join.' }
)}
/>

Expand Down
2 changes: 1 addition & 1 deletion ...omponents/pipeline_processors_editor/components/manage_processor_form/processors/json.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export const Json: FunctionComponent = () => {
<FieldNameField
helpText={i18n.translate(
'xpack.ingestPipelines.pipelineEditor.jsonForm.fieldNameHelpText',
{ defaultMessage: 'Field to be parsed' }
{ defaultMessage: 'Field to parse.' }
)}
/>

Expand Down