Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es-archiver: Drop invalid index settings, support --query flag #76522

Merged
merged 3 commits into from
Sep 3, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/kbn-es-archiver/src/actions/save.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,15 @@ export async function saveAction({
dataDir,
log,
raw,
query,
}: {
name: string;
indices: string | string[];
client: Client;
dataDir: string;
log: ToolingLog;
raw: boolean;
query?: Record<string, any>;
}) {
const outputDir = resolve(dataDir, name);
const stats = createStats(name, log);
Expand All @@ -69,7 +71,7 @@ export async function saveAction({
// export all documents from matching indexes into data.json.gz
createPromiseFromStreams([
createListStream(indices),
createGenerateDocRecordsStream(client, stats, progress),
createGenerateDocRecordsStream({ client, stats, progress, query }),
...createFormatArchiveStreams({ gzip: !raw }),
createWriteStream(resolve(outputDir, `data.json${raw ? '' : '.gz'}`)),
] as [Readable, ...Writable[]]),
Expand Down
13 changes: 12 additions & 1 deletion packages/kbn-es-archiver/src/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ export function runCli() {
`,
flags: {
boolean: ['raw'],
string: ['query'],
help: `
--raw don't gzip the archives
spalger marked this conversation as resolved.
Show resolved Hide resolved
`,
Expand All @@ -140,7 +141,17 @@ export function runCli() {
throw createFlagError('--raw does not take a value');
}

await esArchiver.save(name, indices, { raw });
const query = flags.query;
let parsedQuery;
if (typeof query === 'string') {
try {
parsedQuery = JSON.parse(query);
} catch (err) {
throw createFlagError('--query should be valid JSON');
}
}

await esArchiver.save(name, indices, { raw, query: parsedQuery });
},
})
.command({
Expand Down
7 changes: 6 additions & 1 deletion packages/kbn-es-archiver/src/es_archiver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,19 @@ export class EsArchiver {
* @property {Boolean} options.raw - should the archive be raw (unzipped) or not
* @return Promise<Stats>
*/
async save(name: string, indices: string | string[], { raw = false }: { raw?: boolean } = {}) {
async save(
name: string,
indices: string | string[],
{ raw = false, query }: { raw?: boolean; query?: Record<string, any> } = {}
) {
return await saveAction({
name,
indices,
raw,
client: this.client,
dataDir: this.dataDir,
log: this.log,
query,
});
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('esArchiver: createGenerateDocRecordsStream()', () => {
const progress = new Progress();
await createPromiseFromStreams([
createListStream(['logstash-*']),
createGenerateDocRecordsStream(client, stats, progress),
createGenerateDocRecordsStream({ client, stats, progress }),
]);

expect(progress.getTotal()).to.be(0);
Expand All @@ -74,7 +74,7 @@ describe('esArchiver: createGenerateDocRecordsStream()', () => {
const progress = new Progress();
await createPromiseFromStreams([
createListStream(['logstash-*']),
createGenerateDocRecordsStream(client, stats, progress),
createGenerateDocRecordsStream({ client, stats, progress }),
]);

expect(progress.getTotal()).to.be(0);
Expand Down Expand Up @@ -115,7 +115,7 @@ describe('esArchiver: createGenerateDocRecordsStream()', () => {
const progress = new Progress();
const docRecords = await createPromiseFromStreams([
createListStream(['index1', 'index2']),
createGenerateDocRecordsStream(client, stats, progress),
createGenerateDocRecordsStream({ client, stats, progress }),
createConcatStream([]),
]);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,17 @@ import { Progress } from '../progress';
const SCROLL_SIZE = 1000;
const SCROLL_TIMEOUT = '1m';

export function createGenerateDocRecordsStream(client: Client, stats: Stats, progress: Progress) {
export function createGenerateDocRecordsStream({
client,
stats,
progress,
query,
}: {
client: Client;
stats: Stats;
progress: Progress;
query?: Record<string, any>;
}) {
return new Transform({
writableObjectMode: true,
readableObjectMode: true,
Expand All @@ -41,6 +51,9 @@ export function createGenerateDocRecordsStream(client: Client, stats: Stats, pro
scroll: SCROLL_TIMEOUT,
size: SCROLL_SIZE,
_source: true,
body: {
query,
},
rest_total_hits_as_int: true, // not declared on SearchParams type
} as SearchParams);
remainingHits = resp.hits.total;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ export function createGenerateIndexRecordsStream(client: Client, stats: Stats) {
'-*.settings.index.uuid',
'-*.settings.index.version',
'-*.settings.index.provided_name',
'-*.settings.index.frozen',
'-*.settings.index.search.throttled',
'-*.settings.index.query',
'-*.settings.index.routing',
],
})) as Record<string, any>;

Expand Down