Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA][Code Coverage] Coverage teams lookup w/o Additional Config #77111

Merged
merged 24 commits into from Sep 28, 2020
Merged

[QA][Code Coverage] Coverage teams lookup w/o Additional Config #77111

merged 24 commits into from Sep 28, 2020

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Sep 9, 2020 •
edited

Similar to #74994

However, we are not using a separate config file.

Will resolve #72692

Remove the code that uploaded a team assignment json def, upon every ci run of the code-coverage job.
Add ability to assign teams to all file paths, that are defined in CODEOWNERS (file system crawler).
Also, extend CODEOWNERS definitions to include lines prepended w/ #CC# that only define code coverage team names, not "review alerting" in github.
Integrate this "service" into the code coverage ingestion transforms.

@wayneseymour wayneseymour self-assigned this Sep 9, 2020
@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.0.0 labels Sep 9, 2020
@wayneseymour wayneseymour force-pushed the coverage-teams-lookup-without-ownership-config branch from 9b64852 to e4a82dc Compare September 10, 2020 21:28
@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1102/

@wayneseymour
Copy link
Member Author

The code needs some cleanup still, but let's see how the current build goes first.

@wayneseymour wayneseymour force-pushed the coverage-teams-lookup-without-ownership-config branch 4 times, most recently from 5343e0b to 636f4d3 Compare September 11, 2020 02:49
@wayneseymour
Copy link
Member Author

wayneseymour commented Sep 11, 2020 •
edited

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1104/

@wayneseymour wayneseymour marked this pull request as ready for review September 11, 2020 02:55
@wayneseymour wayneseymour requested review from a team as code owners September 11, 2020 02:55
@wayneseymour wayneseymour force-pushed the coverage-teams-lookup-without-ownership-config branch from 636f4d3 to 6d0e246 Compare September 11, 2020 10:05
@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1105/

@dmlemeshko
Copy link
Member

@elasticmachine merge upstream

dmlemeshko
dmlemeshko reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wayneseymour Great work! What will happen if team assignment file is empty?

src/dev/code_coverage/ingest_coverage/__tests__/enumerate_patterns.test.js Outdated Show resolved Hide resolved
src/dev/code_coverage/ingest_coverage/transforms.js Show resolved Hide resolved
@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1116/

@wayneseymour wayneseymour mentioned this pull request Sep 14, 2020
Closed
@LeeDr
Copy link
Contributor

LeeDr commented Sep 14, 2020

From the most recent Code Coverage job it looks like the paths covered in the existing CODEOWNERS file are getting team assignments. I think we need to add as many of the additional file paths to team relationships into CODEOWNERS as we can to fully test this PR.

@spalger
Copy link
Contributor

spalger commented Sep 14, 2020

I think we need to add as many of the additional file paths to team relationships into CODEOWNERS as we can to fully test this PR.

This is the problem with coupling the two configs together, I don't think it's a good idea to force code owner definitions for teams who don't want to force review of specific code, but maybe I'm being short sighted.

@LeeDr
Copy link
Contributor

LeeDr commented Sep 14, 2020

@spalger it won't cause any additional code reviews. The additional paths will be ignored as comments by github.

@spalger
Copy link
Contributor

spalger commented Sep 14, 2020

Alright, I'm fine giving that a shot

@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1123/

@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1126/

wayneseymour
wayneseymour commented Sep 23, 2020
View reviewed changes
src/dev/code_coverage/ingest_coverage/transforms.js Outdated
);

return pipe(
await grepAndXform(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rylnd I went ahead with your first proposition. Honestly, it was simply easier to grok :)

@wayneseymour
Copy link
Member Author

@elastic/kibana-operations I'd really appreciate a review, particularly on the CODEOWNERS file. @dmlemeshko has already reviewed the js code.

@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1162/

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

1 similar comment
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1164/

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1166/

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

1 similar comment
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1174/

@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1176/

@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/128/

spalger
spalger approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The operations specific changes look good, couple nitpicks

vars/kibanaTeamAssign.groovy Outdated Show resolved Hide resolved
scripts/generate_team_assignments.js Outdated Show resolved Hide resolved
@wayneseymour wayneseymour force-pushed the coverage-teams-lookup-without-ownership-config branch from 4068ccd to 396d4ce Compare September 28, 2020 18:49
@wayneseymour
Copy link
Member Author

https://kibana-ci.elastic.co/job/elastic+kibana+code-coverage/1180/

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wayneseymour wayneseymour merged commit 3a73e0b into master Sep 28, 2020
@wayneseymour wayneseymour deleted the coverage-teams-lookup-without-ownership-config branch September 28, 2020 21:27
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 29, 2020
@phillipb
Merge branch 'add-anomalies-to-timeline' of github.com:phillipb/kiban…
ecee577 
…a into add-anomalies-to-timeline

* 'add-anomalies-to-timeline' of github.com:phillipb/kibana: (89 commits)
  Aligns several module versions across the repository (elastic#78327)
  Empty prompt and loading spinner for service map (elastic#78382)
  Change progress bar to spinner (elastic#78460)
  [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111)
  Slim down core bundle (elastic#75912)
  [Alerting] retry internal OCC calls within alertsClient (elastic#77838)
  [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656)
  [Ingest Manager] Ingest setup upgrade (elastic#78081)
  [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520)
  fix name without a category or if field end with .text (elastic#78655)
  [Security Solution] [Detections] Log message enhancements (elastic#78429)
  [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303)
  [Enterprise Search] Remove all instances of KibanaContext to Kea store (elastic#78513)
  [ML] DF Analytics creation: ensure job did not fail to start before showing results link (elastic#78200)
  fix createAppNavigationHandler to use `navigateToUrl` (elastic#78583)
  Fixing a11y test failure on discover app (elastic#59975) (elastic#77614)
  [Security Solution] Initiate endpoint package upgrade from security app (elastic#77498)
  [kbn/es] use a basic build process (elastic#78090)
  [kbn/optimizer] fix .json extension handling (elastic#78524)
  Fix APM lodash imports (elastic#78438)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 29, 2020
@gmmorris
Merge branch 'master' into actions/test-connector
4943c44 
* master: (365 commits)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  [Security Solution] Fixes url timeline flaky test (elastic#78556)
  adds retryability feature (elastic#78611)
  Aligns several module versions across the repository (elastic#78327)
  Empty prompt and loading spinner for service map (elastic#78382)
  Change progress bar to spinner (elastic#78460)
  [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111)
  Slim down core bundle (elastic#75912)
  [Alerting] retry internal OCC calls within alertsClient (elastic#77838)
  [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656)
  [Ingest Manager] Ingest setup upgrade (elastic#78081)
  [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520)
  fix name without a category or if field end with .text (elastic#78655)
  [Security Solution] [Detections] Log message enhancements (elastic#78429)
  [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 77111 or prevent reminders by adding the backport:skip label.

@LeeDr LeeDr added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@tylersmalley tylersmalley Awaiting requested review from tylersmalley

@brianseeders brianseeders Awaiting requested review from brianseeders

Assignees

@wayneseymour wayneseymour

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[WIP][QA] Canonical Code Coverage Teams and CODEOWNERS Assignment
5 participants
@wayneseymour @dmlemeshko @LeeDr @spalger @kibanamachine