Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Fix UI error when alerting is not available #77179

Merged
merged 4 commits into from
Sep 11, 2020

Conversation

chrisronline
Copy link
Contributor

Resolves #77130

We actually fixed part of this problem in #71846 but it didn't catch all locations. The scenario is on the cluster listing page, when SSL is not enabled or there is a missing encryption key in the config file. This is hard to simulate in dev because the encryption key is automatically set in dev mode.

To test, you need to either create a dist build, or change the above code to not default in dev mode:

diff --git a/x-pack/plugins/encrypted_saved_objects/server/config.ts b/x-pack/plugins/encrypted_saved_objects/server/config.ts
index 9c751a9c67f..5b33c6b80cb 100644
--- a/x-pack/plugins/encrypted_saved_objects/server/config.ts
+++ b/x-pack/plugins/encrypted_saved_objects/server/config.ts
@@ -11,12 +11,12 @@ import { PluginInitializerContext } from 'src/core/server';
 
 export const ConfigSchema = schema.object({
   enabled: schema.boolean({ defaultValue: true }),
-  encryptionKey: schema.conditional(
-    schema.contextRef('dist'),
-    true,
-    schema.maybe(schema.string({ minLength: 32 })),
-    schema.string({ minLength: 32, defaultValue: 'a'.repeat(32) })
-  ),
+  encryptionKey: schema.maybe(schema.string({ minLength: 32 })),
+  //   schema.contextRef('dist'),
+  //   true,
+  //   schema.maybe(schema.string({ minLength: 32 })),
+  //   schema.string({ minLength: 32, defaultValue: 'a'.repeat(32) })
+  // ),
 });

Unfortunately, I don't know of a way to add an automated test around this.

@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit d01598d into elastic:master Sep 11, 2020
@chrisronline chrisronline deleted the monitoring/alerts_always branch September 11, 2020 13:28
chrisronline added a commit to chrisronline/kibana that referenced this pull request Sep 11, 2020
* Ensure we always pass this structure down to avoid any errors in the UI

* Fix tests and also fix inaccurate boolean states

* Fix fixture
chrisronline added a commit that referenced this pull request Sep 11, 2020
…7270)

* Ensure we always pass this structure down to avoid any errors in the UI

* Fix tests and also fix inaccurate boolean states

* Fix fixture
chrisronline added a commit that referenced this pull request Sep 11, 2020
…7271)

* Ensure we always pass this structure down to avoid any errors in the UI

* Fix tests and also fix inaccurate boolean states

* Fix fixture
@chrisronline
Copy link
Contributor Author

Backport

7.x: d0147b1
7.9: 0e12028

jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 14, 2020
…s-for-710

* 'master' of github.com:elastic/kibana: (65 commits)
  Separate url forwarding logic and legacy services (elastic#76892)
  Bump yargs-parser to v13.1.2+ (elastic#77009)
  [Ingest Manager] Shared Fleet agent policy action (elastic#76013)
  [Search] Re-add support for aborting when a connection is closed (elastic#76470)
  [Search] Remove long-running query pop-up (elastic#75385)
  [Monitoring] Fix UI error when alerting is not available (elastic#77179)
  do not log plugin id format warning in dist mode (elastic#77134)
  [ML] Improving client side error handling (elastic#76743)
  [Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (elastic#74357)
  [Docs] some basic searchsource api docs (elastic#77038)
  add  cGroupOverrides to the legacy config (elastic#77180)
  Change saved object bulkUpdate to work across multiple namespaces (elastic#75478)
  [Security Solution][Resolver] Replace Selectable popover with badges (elastic#76997)
  Removing ml-state index from archive (elastic#77143)
  [Security Solution] Add unit tests for histograms (elastic#77081)
  [Lens] Filters aggregation  (elastic#75635)
  [Enterprise Search] Update WS Overview logic to use new config data (elastic#77122)
  Cleanup type output before building new types (elastic#77211)
  [Security Solution] Use safe type in resolver backend (elastic#76969)
  Use proper lodash syntax (elastic#77105)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitoring UI is blank after upgrading to 7.9.1
4 participants