Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] DF Analytics creation wizard: ensure dependent variable options are loaded before showing options box #77202

Closed
wants to merge 2 commits into from
Closed

[ML] DF Analytics creation wizard: ensure dependent variable options are loaded before showing options box #77202

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
255bb5b
ensure depvar options are loaded before showing options box
alvarezmelissa87 Sep 10, 2020
b57a411
Merge branch 'master' into ml-dfanalytics-wizard-depvar
elasticmachine Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...lytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ export const ConfigurationStepForm: FC<CreateAnalyticsStepProps> = ({
const [loadingFieldOptions, setLoadingFieldOptions] = useState<boolean>(false);
const [fieldOptionsFetchFail, setFieldOptionsFetchFail] = useState<boolean>(false);
const [loadingDepVarOptions, setLoadingDepVarOptions] = useState<boolean>(false);
const [loadedDepVarOptions, setLoadedDepVarOptions] = useState<boolean>(false);
const [dependentVariableFetchFail, setDependentVariableFetchFail] = useState<boolean>(false);
const [dependentVariableOptions, setDependentVariableOptions] = useState<
EuiComboBoxOptionOption[]
Expand Down Expand Up @@ -124,7 +125,7 @@ export const ConfigurationStepForm: FC<CreateAnalyticsStepProps> = ({
requiredFieldsError !== undefined ||
unsupportedFieldsError !== undefined;

const loadDepVarOptions = async (formState: State['form']) => {
const loadDepVarOptions = (formState: State['form']) => {
setLoadingDepVarOptions(true);
setMaxDistinctValuesError(undefined);

Expand Down Expand Up @@ -152,11 +153,13 @@ export const ConfigurationStepForm: FC<CreateAnalyticsStepProps> = ({
depVarUpdate = '';
}
setDependentVariableOptions(depVarOptions);
setLoadedDepVarOptions(true);
setLoadingDepVarOptions(false);
setDependentVariableFetchFail(false);
setFormState({ dependentVariable: depVarUpdate });
}
} catch (e) {
setLoadedDepVarOptions(true);
setLoadingDepVarOptions(false);
setDependentVariableFetchFail(true);
}
Expand Down Expand Up @@ -331,7 +334,7 @@ export const ConfigurationStepForm: FC<CreateAnalyticsStepProps> = ({
>
<DataGrid {...indexPreviewProps} />
</EuiFormRow>
{isJobTypeWithDepVar && (
{isJobTypeWithDepVar && loadedDepVarOptions && (
<Fragment>
<EuiFormRow
fullWidth
Expand Down