Add Lens to Recently Accessed #77249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomThomson
changed the title
|
@elasticmachine merge upstream |
flash1293
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Tested in Firefox and works as expected, LGTM. Left a small nit but it's not very important
Currently, this triggers a full page reload if you aren't already within the Lens app and loses the time range and pinned filters while doing so. This is documented in #64629
| @@ -16,3 +16,7 @@ export function getBasePath() { | |||
| export function getEditPath(id: string) { | |||
| return `#/edit/${encodeURIComponent(id)}`; | |||
| } | |||
|
|
|||
| export function getFullPath(id: string) { | |||
| return `/app/${PLUGIN_ID}#/edit/${encodeURIComponent(id)}`; | |||
There was a problem hiding this comment.
nit: This could call getEditPath instead of inlining the logic
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Sep 14, 2020
added lens to recently accessed on load and save in app.tsx
ThomThomson
added a commit
that referenced
this pull request
Sep 14, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 15, 2020
* master: (25 commits) [Security Solution] Add unit tests for Network search strategy (elastic#77416) [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040) [Ingest Manager] Add route for package installation by upload (elastic#77044) [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359) [APM] Remove useLocation and some minor route improvements (elastic#76343) [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258) [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444) Move remaining uses of serviceName away from urlParams (elastic#77248) [Lens] Move configuration popover to flyout (elastic#76046) [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589) skip flaky suite (elastic#59975) Neutral-naming in reporting plugin (elastic#77371) [Enterprise Search] Add UserIcon styles (elastic#77385) [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201) [Ingest Manager] Fix polling for new agent action (elastic#77339) Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212) Stacked headers and navigational search (elastic#72331) [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326) [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099) Add Lens to Recently Accessed (elastic#77249) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A quick implementation to place Lens visualizations in the recently accessed section.
This PR adds to the recently accessed from
app.tsxinstead of through thesavedObjectStoreso that embeddables won't cause an addition.Note that because of: #64629 accessing these links may cause a full page reload.
Checklist
Delete any items that are not applicable to this PR.
For maintainers