Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Added Logic for the Credentials View #77626

Merged
merged 35 commits into from
Sep 28, 2020
Merged

[Enterprise Search] Added Logic for the Credentials View #77626

merged 35 commits into from
Sep 28, 2020

Commits on Sep 16, 2020

  1. Add Logic for the Credentials View

    @JasonStoltz
    JasonStoltz committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    7641d56 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. TS fixes

    @JasonStoltz
    JasonStoltz committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    91392ae View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Removed keyHelpText 

    Text like this doesn't belong in a selector. I will update the view
as needed in a subsequent PR.
    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    3e1fe7d View commit details
    Browse the repository at this point in the history

  2. Whitespace adjustments in credentials test

    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    1fa29d5 View commit details
    Browse the repository at this point in the history

  3. Removed apiUrl from credentials logic 

    This can be replaced by enterpriseSearchUrl in AppLogic.

I also removed unused fields apiTokens and lmAccount.
    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    d1c2444 View commit details
    Browse the repository at this point in the history

  4. Prefer arrow syntax and inlined declarations

    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    8ba4cee View commit details
    Browse the repository at this point in the history

  5. Removed unused code

    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    b2eec73 View commit details
    Browse the repository at this point in the history

  6. Removed unused apiTokenSort

    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    b8a77a2 View commit details
    Browse the repository at this point in the history

  7. Removed TODOs about flashMessages

    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    b6d0fb5 View commit details
    Browse the repository at this point in the history

  8. Fixed bad delete route

    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    08ab4f7 View commit details
    Browse the repository at this point in the history

  9. Move credentials constants to /credentials

    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    33cc9d5 View commit details
    Browse the repository at this point in the history

  10. Moved format_api_name

    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    c80e0c8 View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    @JasonStoltz
    JasonStoltz and Constance committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    18dd7ef View commit details
    Browse the repository at this point in the history

  12. Apply suggestions from code review 

    Co-authored-by: Constance <constancecchen@users.noreply.github.com>
    @JasonStoltz
    JasonStoltz and Constance committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    844f6e2 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into credentials-logic

    @JasonStoltz
    JasonStoltz committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    0ede789 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Suggestion edits and error handling 

    I had to make edits after accepting suggestions. I also added the
tests for the corresponding error handling that was added.
    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    77e519b View commit details
    Browse the repository at this point in the history

  2. Updated formatApiName tests

    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    4ff917d View commit details
    Browse the repository at this point in the history

  3. Updated formatApiName implementation

    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    c715de8 View commit details
    Browse the repository at this point in the history

  4. Prefer arrow syntax in flushPromises

    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    a0d519e View commit details
    Browse the repository at this point in the history

  5. Accepted suggestions for constants file 

    Mainly edits for i18n
    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    fb3d159 View commit details
    Browse the repository at this point in the history

  6. Moved types to public

    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    75eb3c4 View commit details
    Browse the repository at this point in the history

  7. Create ITokenReadWrite type

    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    a83ca06 View commit details
    Browse the repository at this point in the history

  8. Removed unnecessary comment

    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    9111c36 View commit details
    Browse the repository at this point in the history

  9. Removed 'Should not change tests' 

    Removed 'should not change tests' so that this coverage happens
implicitly as part of individual tests.
    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    6347c61 View commit details
    Browse the repository at this point in the history

  10. Dry up tests

    @JasonStoltz
    JasonStoltz committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    b7349e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Revert "Dry up tests" 

    This reverts commit b7349e5.
    @JasonStoltz
    JasonStoltz committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    4e1d616 View commit details
    Browse the repository at this point in the history

  2. Changed the meta type to Partial<IMeta>

    @JasonStoltz
    JasonStoltz committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    c58121b View commit details
    Browse the repository at this point in the history

  3. Adjusted space for consistency and readability

    @JasonStoltz
    JasonStoltz committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    175198d View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Removed flushPromise

    @JasonStoltz
    JasonStoltz committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    585f6e6 View commit details
    Browse the repository at this point in the history

  2. PR Feedback and Coverage

    @JasonStoltz
    JasonStoltz committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    5a46c08 View commit details
    Browse the repository at this point in the history

  3. Loosened up test types

    @JasonStoltz
    JasonStoltz committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    1cd6812 View commit details
    Browse the repository at this point in the history

  4. Moved ICredentialsDetails

    @JasonStoltz
    JasonStoltz committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    defa75f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into credentials-logic

    @JasonStoltz
    JasonStoltz committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    a7db3ed View commit details
    Browse the repository at this point in the history

  6. Moved IApiToken type

    @JasonStoltz
    JasonStoltz committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    7422f90 View commit details
    Browse the repository at this point in the history

  7. Moved error expectations

    @JasonStoltz
    JasonStoltz committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    5437fbd View commit details
    Browse the repository at this point in the history