-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actions] avoids setting a default dedupKey on PagerDuty #77773
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
038039c
avoid setting a default dedupKey
gmmorris 15ea582
fixed pagerduty simulator
gmmorris 560a885
Merge branch 'master' into actions/pagerduty-dedup
elasticmachine ce55b27
Merge branch 'master' into actions/pagerduty-dedup
elasticmachine 528193f
make dedupKey required for resolve and acknowledge
gmmorris 56e81d2
Merge branch 'master' into actions/pagerduty-dedup
gmmorris 06230bf
fixed pagerduty tests
gmmorris 097b99d
Merge branch 'master' into actions/pagerduty-dedup
gmmorris 217a3c3
fixed typing
gmmorris e504af7
fixed test
gmmorris d1b776f
Merge branch 'master' into actions/pagerduty-dedup
elasticmachine 05e0ab3
Merge branch 'master' into actions/pagerduty-dedup
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this change in the interest of making it easier to maintain longer term.
I spent a good few minutes tying to figure out why we were comparing to
null
a value that can only beString
orundefined
... I was convinced this was a bug... it took me embarassingly long to notice the!=
rather than!==
.Damn you Brendan Eich! 😩
To prevent others from going down the same rabbit hole, I've replaced this with an explicit check for
undefined
. :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will change the payload so that previously params that were null were not included in the payload, but now they will, with a value of
null
. If that's ok with the PagerDuty API, then it's fine with me :-)