Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alert add and edit flyout to not close when user clicks outside #78860

Merged

Conversation

mikecote
Copy link
Contributor

Fixes #78239

In this PR, I'm fixing the UX for alert add and edit flyouts. When the user clicks outside the flyout, it will no longer close automatically. This will match the same experience as connector add and edit flyouts.

@mikecote mikecote added release_note:fix Feature:Alerting v8.0.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 labels Sep 29, 2020
@mikecote mikecote self-assigned this Sep 29, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id value diff baseline
triggers_actions_ui 1.5MB -28.0B 1.5MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote marked this pull request as ready for review September 30, 2020 01:23
@mikecote mikecote requested a review from a team as a code owner September 30, 2020 01:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified! Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 v8.0.0
Projects
None yet
4 participants