[TSVB] Allow string fields on value count aggregation #79267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
force-pushed
the
tsvb-allow-strings-value-count
branch
from
dc01edc
to
766cf62
Compare
|
@elasticmachine merge upstream |
stratoula
added
release_note:fix
Feature:TSVB
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
flash1293
reviewed
Oct 5, 2020
| @@ -25,6 +25,7 @@ export function getSupportedFieldsByMetricType(type) { | |||
| case METRIC_TYPES.CARDINALITY: | |||
| return Object.values(KBN_FIELD_TYPES).filter((t) => t !== KBN_FIELD_TYPES.HISTOGRAM); | |||
| case METRIC_TYPES.VALUE_COUNT: | |||
| return [KBN_FIELD_TYPES.NUMBER, KBN_FIELD_TYPES.HISTOGRAM, KBN_FIELD_TYPES.STRING]; | |||
There was a problem hiding this comment.
It seems like value count works for all field types - I changed this to return KBN_FIELD_TYPES and got nice looking charts as well:
There was a problem hiding this comment.
No if it supports them all then I will change it to support them all 🙂 Thanx for that
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Oct 5, 2020
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Oct 6, 2020
* [TSVB] Enable string fields for value count aggregation * fix test title * Allow all field types for value count aggregation Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Oct 6, 2020
* [TSVB] Enable string fields for value count aggregation * fix test title * Allow all field types for value count aggregation Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 6, 2020
* master: (85 commits) Refactor attribute service (elastic#78414) [APM] Add default message to alerts. (elastic#78930) [Discover] Modify columns and sort when switching index pattern (elastic#74336) Document ts project references setup (elastic#78586) build all ts refs in single kbn:bootstrap (elastic#79438) [TSVB] Allow string fields on value count aggregation (elastic#79267) [SECURITY SOLUTION] Investigate EQL signal in timeline (elastic#79049) [Fleet] Add loading spinner to page headers (elastic#79568) [Security Solution][Resolver] Resolver query panel load more (elastic#79160) Add type row to monitor detail page. (elastic#79556) Remove license refresh from setup (elastic#79518) [docker] add reporting fonts (elastic#74806) [SECURITY_SOLUTION][ENDPOINT] Add info about trusted apps to the page subtitle + create flyout (elastic#79558) Trim Hash value before validating it (elastic#79545) Warn users when security is not configured (elastic#78545) update copy styling (elastic#79313) Update dependency @elastic/charts to v23.1.1 (elastic#78459) Introduce geo-threshold alerts (elastic#76285) elastic#76920 Show base breadcrumb when there is an error booting the app (elastic#79571) remove react-intl from kibana and keep it inside only i18n package (elastic#78956) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #67581
Seems that value count aggregation supports non-numeric fields but currently TSVB restricts it to only histogram and number type fields. So in this PR I also allow string fields for this aggregation.
Updated
Allow all field types for this aggregation.
Checklist