[Lens] Improve Lens initial bundle size #79292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Lens
release_note:skip
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
To update your PR or re-run it, just comment with: |
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
commented
Oct 2, 2020
| @@ -83,6 +83,8 @@ export class EmbeddableFactory implements EmbeddableFactoryDefinition { | |||
| indexPatternService, | |||
| } = await this.getStartServices(); | |||
|
|
|||
| const { Embeddable } = await import('../../async_services'); | |||
There was a problem hiding this comment.
loading the actual embeddable async when required
flash1293
commented
Oct 2, 2020
| @@ -7,7 +7,7 @@ | |||
| import { Capabilities, HttpSetup } from 'kibana/public'; | |||
| import { i18n } from '@kbn/i18n'; | |||
| import { RecursiveReadonly } from '@kbn/utility-types'; | |||
| import { toExpression, Ast } from '@kbn/interpreter/target/common'; | |||
| import { Ast } from '@kbn/interpreter/target/common'; | |||
There was a problem hiding this comment.
Don't load code from interpreter within the factory (because it's part of the initial bundle)
flash1293
commented
Oct 2, 2020
| @@ -25,10 +25,8 @@ import { Document } from '../persistence/saved_object_store'; | |||
| import { mergeTables } from './merge_tables'; | |||
| import { formatColumn } from './format_column'; | |||
| import { EmbeddableFactory, LensEmbeddableStartServices } from './embeddable/embeddable_factory'; | |||
| import { getActiveDatasourceIdFromDoc } from './editor_frame/state_management'; | |||
There was a problem hiding this comment.
Load some helpers async when needed because they pull in a tail of other modules
wylieconlon
approved these changes
Oct 2, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 5, 2020
flash1293
added a commit
that referenced
this pull request
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the initial bundle size of Lens by moving a few more files behind the lazy import boundary in
async_services.Most of the changes are due to the fact the embeddable got the static
toExpressionfunction of the interpreter passed in as parameter (I guess this was done to simplify unit testing). I switched to a different approach here (mocking the result ofdocumentToExpression) which made that unnecessary.