Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tunes ML related text on Metrics UI #79425

Merged
merged 7 commits into from Oct 6, 2020
Merged

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Oct 5, 2020

Summary

This PR applies small changes to the ML related Metrics UI text:

  • uses sentence caps for button text,
  • changes the text on cards to differentiate Hosts and Kubernetes Pods,
  • makes explanatory text shorter on Enable ML... screen.

New state:
Screenshot 2020-10-05 at 12 18 36

Checklist

Delete any items that are not applicable to this PR.

@szabosteve szabosteve requested a review from a team as a code owner October 5, 2020 09:58
@szabosteve szabosteve requested a review from lcawl October 5, 2020 09:59
@szabosteve szabosteve marked this pull request as draft October 5, 2020 10:04
@szabosteve szabosteve added :ml backport Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.10.0 v8.0.0 WIP Work in progress labels Oct 5, 2020
@lcawl
Copy link
Contributor

lcawl commented Oct 5, 2020

I think we should also remove the capitalization from "Enable machine learning for hosts" title shown in the screenshot.

@szabosteve szabosteve marked this pull request as ready for review October 5, 2020 16:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl
Copy link
Contributor

lcawl commented Oct 5, 2020

With respect to the description under "How do you want to partition your data?", I'm hoping we can make it more concise too. Something like this: "Partitions enable you to build independent models for groups of data that share similar behavior. For example, you can partition by machine type or cloud availability zone.

@szabosteve szabosteve removed the WIP Work in progress label Oct 5, 2020
…nents/ml/anomaly_detection/job_setup_screen.tsx

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
…nents/ml/anomaly_detection/job_setup_screen.tsx
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
infra 3.8MB 3.8MB -273.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@szabosteve szabosteve merged commit b7057bc into elastic:master Oct 6, 2020
@szabosteve szabosteve deleted the met.ml branch October 6, 2020 14:25
szabosteve added a commit that referenced this pull request Oct 7, 2020
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
gmmorris added a commit that referenced this pull request Oct 8, 2020
…into feature/task_manager_429

* 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits)
  Add license check to direct package upload handler. (#79653)
  [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193)
  [Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594)
  Fine-tunes ML related text on Metrics UI (#79425)
  [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (#79229)
  Add new "Add Data" tutorials (#77237)
  Update APM telemetry docs (#79583)
  Revert "Add support for runtime field types to mappings editor. (#77420)" (#79611)
  Kibana request headers (#79218)
  ensure missing indexPattern error is bubbled up to error callout (#79378)
  Missing space fix (#79585)
  remove duplicate tab states (#79501)
  [data.ui] Lazy load UI components in data plugin. (#78889)
  Add generic type params to search dependency. (#79608)
  [Ingest Manager] Internal action for policy reassign (#78493)
  [ILM] Add index_codec to forcemerge action in hot and warm phases (#78175)
  [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (#79579)
  [ML] Hide Data Grid column options when histogram charts are enabled. (#79459)
  [Telemetry] Synchronous `setup` and `start` methods (#79457)
  [Observability] Persist time range across apps (#79258)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Feature:Metrics UI Metrics UI feature :ml release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants