Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telemetry] Synchronous setup and start methods #79457

Merged
merged 5 commits into from Oct 6, 2020
Merged

[Telemetry] Synchronous setup and start methods #79457

merged 5 commits into from Oct 6, 2020

Commits on Oct 5, 2020

  1. [Telemetry] Synchronous setup and start methods

    @afharo
    afharo committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    f0f8d9e View commit details
    Browse the repository at this point in the history

  2. Wait for the old UI settings to be ported before reaching the `getTel… 

    …emetrySavedObject`
    @afharo
    afharo committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    25ec67f View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary !

    @afharo
    afharo committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    2951a62 View commit details
    Browse the repository at this point in the history

  4. Use AsyncSubject instead of ReplaySubject

    @afharo
    afharo committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    753c581 View commit details
    Browse the repository at this point in the history

  5. No need for the .next method in the AsyncSubject

    @afharo
    afharo committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    16539c3 View commit details
    Browse the repository at this point in the history