Add timelion to kibana core

[rashidkpc]

This adds the, currently external, elastic/timelion plugin to the Kibana core.

[rashidkpc]

Ok, definitely not this pull causing these failures. Master has been failing with the same issue: https://kibana-ci.elastic.co/job/elastic+kibana+master+multijob-intake/133/console

[epixa]

@rashidkpc Can you rebase or merge master into this? I'd like to see if the upgrade to karma and node have improved the situation.

[rashidkpc]

@epixa done. Also added the .log() function from upstream elastic/timelion

[rashidkpc]

Look, I fixed it.

[karmi]

Hi @rashidkpc, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

[epixa]

Damn, I can't get this running locally without getting [error][status][ui settings] Status changed from green to red - Could not find user-provided settings on startup. Trying to dig around now

[rashidkpc]

Strange haven't seen that one.

[epixa]

It's not happening on master, but I can reproduce it consistently with this PR whenever Elasticsearch is new (so there is no kibana index). Timelion appears to still be functional, so I'm not sure what the downside is, but we obviously don't want startup errors in the first time use case.

Other than that, the only other thing I noticed is the logo replacement: can you update it so Timelion is not replacing the Kibana logo? Since the logo/name are highlighted in the side nav, no core applications are replacing the Kibana logo anymore.

[epixa]

It actually sounds like Spencer knows what the deal is here, so I'm chatting with him about it.

[epixa]

@rashidkpc Are you retrieving and setting advanced settings during plugin initialization? The advanced settings thing really doesn't support that in its current form.

So right now, this is technically at risk of not working during any startup since it's a timing issue, but it tends to only manifest during the initial startup since the kibana index is being created. The end result of the failure is that the timelion advanced settings do not get added on initial start, and then if you restart kibana they get added.

If you really want the configuration accessible in advanced settings, then the only real option at the moment is to add them directly to the application-wide defaults: https://github.com/elastic/kibana/blob/master/src/ui/settings/defaults.js

As an alternative, I propose adding them to kibana.yml instead. If I understand correctly, they were in timelion.json before anyway, so it has traditionally been static file based configuration.

[rashidkpc]

@epixa I've already added them to defaults.js a1f5434

Edit: I removed the old config population stuff anyway.

[epixa]

That did it!

[epixa]

LGTM

I don't want to sweat over things like style for a separate plugin of this size. We can always address anything like that later.

[ddavidebor]

@rashidkpc should we continue to use your timelion-random example plugin to develop?

[rashidkpc]

@ddavidebor Do continue to use the example, though you'll need to update the require paths (eg, to alter.js) in the examples. Once there's a release with timelion in it I'll update the examples