[Monitoring] Fix bug with setup mode appearing on pages it shouldn't #80343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
@igoristic Hold off on this review. I think we can fix this a better way. |
|
@igoristic Nevermind. I think we need to make this better but it'll be easier once we rid ourselves of angular routing. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
igoristic
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
@chrisronline Love the use of React context here! ❤️
Works as expected, and seems to also fix the Cannot read property 'elasticsearch' of null triggered in setup_mode.js due to null/undefined data reported earlier
This was referenced Oct 20, 2020
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Oct 20, 2020
…lastic#80343) * Ensure we check for local setup mode data first * Use a context to ensure deeply nested components have access * Fix snapshots Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline
added a commit
that referenced
this pull request
Oct 20, 2020
…80343) (#81101) * Ensure we check for local setup mode data first * Use a context to ensure deeply nested components have access * Fix snapshots Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 20, 2020
…lout-for-warm-and-cold-tier * 'master' of github.com:elastic/kibana: (126 commits) Add cumulative sum expression function (elastic#80129) [APM] Fix link to trace (elastic#80993) Provide url rewritten in onPreRouting interceptor (elastic#80810) limit renovate to npm packages Fix bug in logs UI link (elastic#80943) [Monitoring] Fix bug with setup mode appearing on pages it shouldn't (elastic#80343) [Security Solution][Detection Engine] Fixes false positives caused by empty records in threat list docs test (elastic#81080) Fixed alerts ui test timeout issue, related to the multiple server calls for delete all alerts, by reducing the number of alerts to the two and increasing retry timeout. (elastic#81067) [APM] Fix service map highlighted edge on node select (elastic#80791) Fix typo in toast, slight copy adjustment. (elastic#80843) [Security Solution] reduce optimizer limits (elastic#80997) [maps] 7.10 documentation updates (elastic#79917) [Workplace Search] Fix Group Prioritization route and clean up design (elastic#80903) [Enterprise Search] Added reusable HiddenText component to Credentials (elastic#80033) Upgrade EUI to v29.5.0 (elastic#80753) [Maps] Fix layer-flash when changing style (elastic#80948) [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (elastic#80220) [Enterprise Search] Handle loading state on Credentials page (elastic#80035) [Monitoring] Fix cluster listing page in how it handles global state (elastic#78979) ...
chrisronline
added a commit
that referenced
this pull request
Oct 20, 2020
…80343) (#81100) * Ensure we check for local setup mode data first * Use a context to ensure deeply nested components have access * Fix snapshots Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79477
#73127 introduced a slight change in how we handle determining if setup mode UIs should appear.
There are two parts of detecting setup mode - there is a global component but also a custom renderer that is meant to determine if setup mode should appear or not (on the particular page).
The change in #73127 changed a couple of spots in code to only look at the global component but it really needs to look at both.
To test, navigate to Stack Monitoring and then click on a page that does not support setup mode (such as Elasticsearch -> Indices) and make sure no setup mode UIs appear.