[Lens] Implement time scaling function #82104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, test this. |
flash1293
added
Feature:Lens
Team:AppArch
Team:Visualizations
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lukeelmers
approved these changes
Nov 3, 2020
Comment on lines
+109
to
+110
| from: '2020-10-05T00:00:00.000Z', | ||
| to: '2020-10-10T00:00:00.000Z', |
There was a problem hiding this comment.
I wonder if we should also add a test for the new case that is introduced in this PR where we fall back to interval if the appliedTimeRange is undefined
There was a problem hiding this comment.
Good point - we always had this case but the types didn't reflect it. Actually it's an error case, I extended the condition to throw an error and added unit tests.
|
@elasticmachine merge upstream |
mbondyra
approved these changes
Nov 6, 2020
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Nov 6, 2020
flash1293
added a commit
that referenced
this pull request
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77692
Adds
lens_time_scalefunction to scale numbers by time bucket.The time scale function takes the following arguments:
This function fails if there is no meta data on the date column to determine the used time zone, time range and interval.
It builds on top of the
getDateMetaByDatatableColumnadded in a previous PR, but one change was necessary.Right now, the applied time range is added to the column meta data using the input date math range (e.g. from
now-24htonow). This is problematic because due to async search the time scale function could get triggered much later than the actual query hitting Elasticsearch - this would skew the size of the first and last bucket in the time range and produce wrong scaling for those buckets. By resolving the date range directly before sending the request to Elasticsearch and converting it into ISO strings for from and to, the time scaling will be very close to exact even for long running searches.