Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding non-space aware checks for existing jobs #82814

Merged
merged 4 commits into from Nov 10, 2020
Merged

[ML] Adding non-space aware checks for existing jobs #82814

merged 4 commits into from Nov 10, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Nov 6, 2020 •
edited

Endpoints for checking to see whether jobs exist in any spaces.
To be used in the wizards to prevent job id reuse in a user friendly way.

@jgowdyelastic jgowdyelastic added :ml Feature:Anomaly Detection ML anomaly detection Feature:Data Frame Analytics ML data frame analytics features labels Nov 6, 2020
@jgowdyelastic jgowdyelastic marked this pull request as ready for review November 6, 2020 12:06
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 6, 2020 12:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic mentioned this pull request Nov 6, 2020
Closed
13 tasks
peteharverson
peteharverson approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic jgowdyelastic merged commit dc287ea into elastic:master Nov 10, 2020
@jgowdyelastic jgowdyelastic deleted the adding-non-space-aware-job-exists-checks branch November 10, 2020 20:54
@jgowdyelastic jgowdyelastic mentioned this pull request Nov 10, 2020
Merged
jgowdyelastic added a commit that referenced this pull request Nov 11, 2020
@jgowdyelastic @kibanamachine
[ML] Adding non-space aware checks for existing jobs (#82814) (#83114)
d0603dc 
* [ML] Adding non-space aware checks for existing jobs

* merge with existing jobs exist endpoint

* updating comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection Feature:Data Frame Analytics ML data frame analytics features :ml release_note:enhancement review v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson