[Lens] Provide single-value functions to show the "Last" value of some field #83437

mbondyra · 2020-11-16T15:47:01Z

Summary

This PR adds new type of metric operation last value – it has the same behavior as Visualize 'top_hits' but with some limitations prioritizing user experience. Here's the behavior description:

only one last value is displayed,
value can be only sorted by time fields (so it's the last value in time). If there's no timefields in the index pattern, operation cannot be used
for numerical fields, the value can be formatted
charts (xy and pie) can only accept numerical values. Metric and datatable accept all types.
operation cannot be used on rollup index patterns
operation is never default when fields are dragged to droppable areas

Here's the example screenshots:

When there's no timefield:

When the time field was removed from index and there's invalid reference:

I changed the messaging in error handling – now we don't use names of fields, but the label of column. I think it's a change for better because it's much easier for the user to identify the place where the reference has to be fixed.

With numeric arrays for metric on pie (or y-accessors for xy chart)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

mbondyra · 2020-11-18T13:27:38Z

@elasticmachine merge upstream

elasticmachine · 2020-11-18T16:01:00Z

Pinging @elastic/kibana-app (Team:KibanaApp)

myasonik

Just a minor a11y question but want an actual designer to take a look at my Sass comment but otherwise LGTM

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx

x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.scss

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx

dej611 · 2020-11-19T10:27:08Z

Code looks good 👍 , just two minor changes proposed. Will test locally next 🚀

flash1293

As this is a new place to store a field reference, we should

add it to the validation logic in x-pack/plugins/lens/public/indexpattern_datasource/utils.ts#getInvalidLayers
Handle missing fields in the UI similar to how it's done for invalid sourceFields

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/terms/index.tsx

mbondyra · 2020-11-23T08:06:32Z

@elasticmachine merge upstream

…anel/dimension_editor.tsx

mbondyra · 2020-11-25T08:40:52Z

@elasticmachine merge upstream

flash1293

This looks great! Left some minor comments

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts

…st_value # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts

flash1293 · 2020-11-30T07:17:10Z

@elasticmachine merge upstream

flash1293

Tested and LGTM

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx

MichaelMarcialis

This is looking great, @mbondyra! Left a few comments for your review.

...k/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/warnings_popover.tsx

x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx

…t_value # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/count.tsx # x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts # x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/metrics.tsx

MichaelMarcialis

Thank you for making those previous changes. I've left a few more minor stylistic change requests/comments, but I'll approve now so as not to hold you up any further.

...k/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/warnings_popover.tsx

.../plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/warnings_popover.scss

wylieconlon

The functionality is working, including error states- most of my comments are about the form design. I'm hoping we can make a more user-friendly form design like we talked about, by removing the words "sort order" from the UI.

x-pack/plugins/lens/public/indexpattern_datasource/indexpattern.tsx

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx

wylieconlon · 2020-12-01T20:51:23Z

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx

+          })}
+          isInvalid={isSortFieldInvalid}
+        >
+          <EuiComboBox


I can't blur this combobox on click outside. Is it configured differently than usual? Something seems wrong.

I cannot reproduce it. Can you send me a video or let's talk during sync.

wylieconlon

I haven't re-tested it, but I'm approving now that sort order is removed. The form UI issue is something I'm not just seeing on your PR, so let's deal with it separately.

…t_value # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx

…alue of some field (elastic#83437)

…alue of some field (#83437) (#84815)

kibanamachine · 2020-12-04T12:21:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 51e0830

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`lens`	447	458	+11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	972.6KB	995.5KB	+22.9KB

Distributable file count

id	before	after	diff
`default`	43205	43206	+1

History

💚 Build #91423 succeeded 51e0830
💔 Build #91398 failed f072f69
💔 Build #91368 failed af5f00e
💚 Build #91043 succeeded b42d0c5
💚 Build #90975 succeeded 15ba028

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

feat: last value sketch

e2354f5

mbondyra added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.11.0 labels Nov 16, 2020

mbondyra added 4 commits November 17, 2020 15:01

feat: rollup indices

6a6dd4e

added disabledStatus

f807858

update old tests

4555d51

tests added

2e3708f

Merge branch 'master' into lens/last_value

1f7b713

This was referenced Nov 18, 2020

[Lens] [Visualize] Formatting last_value/top_hits metric for array values #83637

Closed

[Lens] Show notification when data for y column or 'size by' is not-numerical #83655

Closed

mbondyra marked this pull request as ready for review November 18, 2020 16:00

mbondyra requested a review from a team November 18, 2020 16:00

mbondyra requested a review from a team as a code owner November 18, 2020 16:00

elastic deleted a comment from apmmachine Nov 18, 2020

myasonik reviewed Nov 18, 2020

View reviewed changes

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx Outdated Show resolved Hide resolved

x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.scss Show resolved Hide resolved

fix i18n message

df8c5ee

ryankeairns mentioned this pull request Nov 18, 2020

[EuiListGroupItem] Make the extraAction prop less restrictive elastic/eui#4285

Closed

dej611 reviewed Nov 19, 2020

View reviewed changes

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx Outdated Show resolved Hide resolved

dej611 reviewed Nov 19, 2020

View reviewed changes

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx Outdated Show resolved Hide resolved

mbondyra added 2 commits November 20, 2020 09:59

cr

0c14e4c

(experimental) don't add icon

dba38a5

flash1293 reviewed Nov 20, 2020

View reviewed changes

fix transferable

1357868

Update x-pack/plugins/lens/public/indexpattern_datasource/dimension_p…

3e4b5f7

…anel/dimension_editor.tsx

Merge branch 'master' into lens/last_value

b3218a6

flash1293 reviewed Nov 25, 2020

View reviewed changes

mbondyra added 3 commits November 26, 2020 11:12

Merge branch 'lens/accessibility-suggestions-name-focus' into lens/la…

5be70e4

…st_value # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts

refactor hasInvalidReferences to getErrorMessage

2f844b8

ts

85f3503

Merge branch 'master' into lens/last_value

f79cafa

flash1293 approved these changes Nov 30, 2020

View reviewed changes

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts Show resolved Hide resolved

x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/last_value.tsx Outdated Show resolved Hide resolved

copy change to more human

808bc29

MichaelMarcialis reviewed Nov 30, 2020

View reviewed changes

mbondyra added 2 commits December 1, 2020 10:23

design changes

15ba028

MichaelMarcialis approved these changes Dec 1, 2020

View reviewed changes

designs

b42d0c5

wylieconlon suggested changes Dec 1, 2020

View reviewed changes

design

af5f00e

wylieconlon approved these changes Dec 2, 2020

View reviewed changes

mbondyra added 2 commits December 2, 2020 17:28

remove sortOrder

f84c9b5

Merge commit 'c73de2677337e4054954c068744f8b29ab3ce29c' into lens/las…

51e0830

…t_value # Conflicts: # x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx

mbondyra force-pushed the lens/last_value branch from f072f69 to 51e0830 Compare December 2, 2020 16:39

mbondyra merged commit 6900ce2 into elastic:master Dec 2, 2020

mbondyra deleted the lens/last_value branch December 2, 2020 18:56

mbondyra added a commit to mbondyra/kibana that referenced this pull request Dec 2, 2020

[Lens] Provide single-value functions to show the "First" or "Last" v…

f9e7cb0

…alue of some field (elastic#83437)

mbondyra mentioned this pull request Dec 2, 2020

[7.x] [Lens] Provide single-value functions to show the "First" or "Last" value of some field (#83437) #84815

Merged

mbondyra added a commit that referenced this pull request Dec 3, 2020

[Lens] Provide single-value functions to show the "First" or "Last" v…

88f38a7

…alue of some field (#83437) (#84815)

flash1293 changed the title ~~[Lens] Provide single-value functions to show the "First" or "Last" value of some field~~ [Lens] Provide single-value functions to show the "First" value of some field Dec 4, 2020

flash1293 changed the title ~~[Lens] Provide single-value functions to show the "First" value of some field~~ [Lens] Provide single-value functions to show the "Last" value of some field Dec 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Provide single-value functions to show the "Last" value of some field #83437

[Lens] Provide single-value functions to show the "Last" value of some field #83437

mbondyra commented Nov 16, 2020 •

edited

Loading

mbondyra commented Nov 18, 2020

elasticmachine commented Nov 18, 2020

myasonik left a comment

dej611 commented Nov 19, 2020

flash1293 left a comment

mbondyra commented Nov 23, 2020

mbondyra commented Nov 25, 2020

flash1293 left a comment

flash1293 commented Nov 30, 2020

flash1293 left a comment

MichaelMarcialis left a comment

MichaelMarcialis left a comment

wylieconlon left a comment

wylieconlon Dec 1, 2020

mbondyra Dec 2, 2020

wylieconlon left a comment

kibanamachine commented Dec 4, 2020

[Lens] Provide single-value functions to show the "Last" value of some field #83437

[Lens] Provide single-value functions to show the "Last" value of some field #83437

Conversation

mbondyra commented Nov 16, 2020 • edited Loading

Summary

Checklist

mbondyra commented Nov 18, 2020

elasticmachine commented Nov 18, 2020

myasonik left a comment

Choose a reason for hiding this comment

dej611 commented Nov 19, 2020

flash1293 left a comment

Choose a reason for hiding this comment

mbondyra commented Nov 23, 2020

mbondyra commented Nov 25, 2020

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 commented Nov 30, 2020

flash1293 left a comment

Choose a reason for hiding this comment

MichaelMarcialis left a comment

Choose a reason for hiding this comment

MichaelMarcialis left a comment

Choose a reason for hiding this comment

wylieconlon left a comment

Choose a reason for hiding this comment

wylieconlon Dec 1, 2020

Choose a reason for hiding this comment

mbondyra Dec 2, 2020

Choose a reason for hiding this comment

wylieconlon left a comment

Choose a reason for hiding this comment

kibanamachine commented Dec 4, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Distributable file count

History

mbondyra commented Nov 16, 2020 •

edited

Loading