Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Disallow dashes in namespace strings #83996

Merged
merged 3 commits into from Nov 23, 2020
Merged

[Fleet] Disallow dashes in namespace strings #83996

merged 3 commits into from Nov 23, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

Fixes #82922. Prevent dashes in namespace strings.

@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v7.10.1 labels Nov 20, 2020
@jen-huang jen-huang requested a review from a team November 20, 2020 22:30
@jen-huang jen-huang self-assigned this Nov 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang mentioned this pull request Nov 20, 2020
Closed
@jen-huang
Copy link
Contributor Author

@elasticmachine merge upstream

@jen-huang
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 374.6KB 374.6KB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang merged commit 97c9fc2 into elastic:master Nov 23, 2020
@jen-huang jen-huang deleted the ingest/fix/dash-in-namespace branch November 23, 2020 17:51
This was referenced Nov 23, 2020
Merged
Merged
jen-huang added a commit to jen-huang/kibana that referenced this pull request Nov 23, 2020
@jen-huang
Disallow dashes in namespace strings (elastic#83996)
5650234 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/fleet/common/services/is_valid_namespace.test.ts
#	x-pack/plugins/fleet/common/services/is_valid_namespace.ts
jen-huang added a commit that referenced this pull request Nov 23, 2020
@jen-huang
Disallow dashes in namespace strings (#83996) (#84135)
8c3e6d5 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/fleet/common/services/is_valid_namespace.test.ts
#	x-pack/plugins/fleet/common/services/is_valid_namespace.ts
jen-huang added a commit that referenced this pull request Nov 23, 2020
@jen-huang @kibanamachine
Disallow dashes in namespace strings (#83996) (#84133)
b93b265 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dikshachauhan-qasource
Copy link

Hi @EricDavisX

We have validated this ticket on 7.10.1 BC1 Kibana cloud build and found it Fixed. Build details are as follows:

BUILD 36050
COMMIT 1d4cfde288ede0c4bc6277b4d589ca0cb96b231f

Validated areas are :

  • Editing existing policies namespaces
  • Adding new policies namespaces
  • Editing existing integrations namespaces
  • Adding new integrations namespaces

Screenshot:
#83996_Working_Fine

@jen-huang jen-huang mentioned this pull request Jan 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@jen-huang jen-huang

Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.10.1 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ingest manager][BUG] namespace validation misses check for '-' in namespaces
5 participants
@jen-huang @elasticmachine @kibanamachine @dikshachauhan-qasource @nchaulet