Bump highlight.js to v9.18.5 #84296

dependabot · 2020-11-25T00:19:52Z

Bumps highlight.js from 9.15.10 to 10.1.2.

Release notes

10.1.2

Fixes:

fix(night) Prevent object prototype values from being returned by getLanguage (#2636) night

10.1.1

Fixes:

Resolve issue on Node 6 due to dangling comma (#2608) [Edwin Hoogerbeets][]

Resolve index.d.ts is not a module error (#2603) [Josh Goebel][]

10.1.0

Just your typical minor release. Plenty of fixes and enhancements, few new themes.

Some deprecations language maintainers might want to pay attention to:

htmlbars grammar is now deprecated. Use handlebars instead. (#2344) [Nils Knappmeier][]

when using highlightBlock result.re deprecated. Use result.relevance instead. (#2552) [Josh Goebel][]

ditto for result.second_best.re => result.second_best.relevance (#2552)

lexemes is now deprecated in favor of keywords.$pattern key (#2519) [Josh Goebel][]

endSameAsBegin is now deprecated. (#2261) [Josh Goebel][]

10.0.2

Fixes a serious potential freeze/infinite loop issue. Everyone on version 10 should upgrade.

Remove support for AMD module loading, which never truly worked properly anyways.

10.0.1

Fixes: sublanguage with no rule matches causes text to disappear in final output. (#2506).

10.0.0

Welcome to version 10.0. This a major release and therefore will contain breaking changes.

Breaking Changes

Our normal minor releases try to never break anything, holding all breaking changes for major releases. We tried to squeeze in as many as we could this time so that after 10.0 ships we'll be back to quiet sailing for a while before we need to push version 11. That said, we're very conservative about what we consider a breaking change.

i.e., if there it could possibly break things for anyone, it's typically a breaking change. The fact is a vast majority of users should upgrade and probably not notice any changes at all.

See VERSION_10_BREAKING_CHANGES.md for a comprehensive list of breaking changes, but here is a summary... if you use:

Core highlight.js lib on the client (with no extra CDN languages)

Just keep doing that.

If you're using darkula.css, you'll need to change that to darcula.css

... (truncated)

Changelog

Sourced from highlight.js's changelog.

Version 10.1.2

Fixes:

fix(night) Prevent object prototype values from being returned by getLanguage (#2636) night

Version 10.1.1

Fixes:

Resolve issue on Node 6 due to dangling comma (#2608) Edwin Hoogerbeets

Resolve index.d.ts is not a module error (#2603) Josh Goebel

Version 10.1.0

New themes:

NNFX and NNFX-dark by [Jim Mason][]

lioshi by [lioshi][]

Parser Engine:

(parser) Now escapes quotes in text content when escaping HTML (#2564) Josh Goebel

(parser) Adds keywords.$pattern key to grammar definitions (#2519) Josh Goebel

(parser) Adds SHEBANG utility mode Josh Goebel

(parser) Adds registerAliases method (#2540) [Taufik Nurrohman][]

(enh) Added on:begin callback for modes (#2261) Josh Goebel

(enh) Added on:end callback for modes (#2261) Josh Goebel

(enh) Added ability to programatically ignore begin and end matches (#2261) Josh Goebel

(enh) Added END_SAME_AS_BEGIN mode to replace endSameAsBegin parser attribute (#2261) Josh Goebel

(fix) fixMarkup would rarely destroy markup when useBR was enabled (#2532) Josh Goebel

Deprecations:

htmlbars grammar is now deprecated. Use handlebars instead. (#2344) [Nils Knappmeier][]

when using highlightBlock result.re deprecated. Use result.relevance instead. (#2552) Josh Goebel

ditto for result.second_best.re => result.second_best.relevance (#2552)

lexemes is now deprecated in favor of keywords.$pattern key (#2519) Josh Goebel

endSameAsBegin is now deprecated. (#2261) Josh Goebel

Language Improvements:

fix(groovy) strings are not allowed inside ternary clauses (#2217) Josh Goebel

... (truncated)

Commits

edd73d2 bump v10.1.2
7241013 (parser) use null prototype objects for languages/aliases (#2636)
93fd0d7 bump v10.1.1; (chore) add changelog for 10.1.1
c5783d2 (chore) clean up types just a little
a4ee4e4 (chore) declare ambient modules for lib/core & languges
0656588 (chore) removed dangling comma (#2612)
b1bce6e (chore) more import below metadata comment
74de6ea (chore) bump copyright
b2d19b0 bump v10.1.0
84f7fa3 (chore) upgrade some dev stuff to newer versions
Additional commits viewable in compare view

Maintainer changes

This version was pushed to npm by isagalaev, a new releaser for highlight.js since your current version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.15.10 to 10.1.2. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/10.1.2/CHANGES.md) - [Commits](highlightjs/highlight.js@9.15.10...10.1.2) Signed-off-by: dependabot[bot] <support@github.com>

kibanamachine · 2020-11-25T00:19:54Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

This reverts commit 929c766.

Includes transitive dependencies.

jportner · 2020-11-25T22:41:02Z

Jenkins test this

watson · 2020-11-26T10:30:17Z

I think we might need to bump highlight.js in @elastic/eui first: elastic/eui#4313

jportner · 2020-12-07T18:23:38Z

Jenkins test this

Had to upgrade react-syntax-highlighter too. Fingers crossed.

jportner

Author's notes.

jportner · 2020-12-07T21:13:38Z

package.json

-    "react-syntax-highlighter": "^5.7.0",
+    "react-syntax-highlighter": "^15.3.1",


The existing dependency paths are:

react-syntax-highlighter@5.8.0 > highlight.js@9.12.0 react-syntax-highlighter@5.8.0 > lowlight@1.9.1 > highlight.js@9.12.0

I needed to upgrade the (years out-of-date) react-syntax-highlighter package so I could bump its transitive dependencies of highlight.js to ^10.4.1.

@elastic/apm-ui, you are the only consumer of this package in Kibana. I read the react-syntax-highlighter changelog and updated DatabaseContext & Context components accordingly. The unit tests are passing but I couldn't figure out how to access these in a manual smoke test. If you could please take a look it would be much appreciated!

jportner · 2020-12-07T21:16:25Z

package.json

@@ -96,6 +96,8 @@
    "**/minimist": "^1.2.5",
    "**/node-jose/node-forge": "^0.10.0",
    "**/prismjs": "1.22.0",
+    "**/react-syntax-highlighter": "^15.3.1",


Forcefully resolves:

@storybook/components > react-syntax-highlighter@12.2.1 to ^15.3.1

See react-syntax-highlighter changelog.

jportner · 2020-12-07T21:16:27Z

package.json

@@ -96,6 +96,8 @@
    "**/minimist": "^1.2.5",
    "**/node-jose/node-forge": "^0.10.0",
    "**/prismjs": "1.22.0",
+    "**/react-syntax-highlighter": "^15.3.1",
+    "**/react-syntax-highlighter/**/highlight.js": "^10.4.1",


Forcefully resolves:

react-syntax-highlighter > highlight.js@^10.1.1 to ^10.4.1

react-syntax-highlighter > lowlight > highlight.js@~10.1.0 to ^10.4.1

See highlight.js changelog.

jportner · 2020-12-07T21:36:01Z

Jenkins test this

sorenlouv · 2020-12-08T00:20:45Z

package.json

@@ -681,7 +683,7 @@
    "has-ansi": "^3.0.0",
    "hdr-histogram-js": "^1.2.0",
    "he": "^1.2.0",
-    "highlight.js": "9.15.10",
+    "highlight.js": "^9.18.5",


Did you decide no to bump to 10.2? Moving away from 9.x sounds like a good idea

Yeah, I was trying to avoid too many changes in this PR, as I don't own the code that consumes highlight.js and I'm not sure I fully understand the implications of the breaking changes. I just wanted to bump to 9.latest until we get a chance to do a major version upgrade. It's worth noting that EUI currently relies on 9.latest as well (as of last week), but they plan to upgrade sometime soon.

jportner · 2020-12-08T13:47:40Z

Failed because of an unrelated flaky test, merging upstream and retesting.

jportner · 2020-12-08T13:47:46Z

@elasticmachine merge upstream

jportner · 2020-12-08T14:16:00Z

Jenkins test this

watson

LGTM (I haven't had the chance to test this out locally though - I'm afk)

sorenlouv · 2020-12-08T15:00:13Z

There might be a linebreak issue with ruby highlighting.

Before

After

I'll try to investigate.

The old version of react-syntax-highlighter would ignore newline characters. This version renders them in the DOM instead. I had to update a component to remove newline characters from the ends of line strings so they would render as expected.

jportner · 2020-12-08T17:10:11Z

Jenkins test this

kibanamachine · 2020-12-08T18:51:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2be72fa

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1153	1720	+567

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.1MB	5.4MB	⚠️ +2.3MB
`enterpriseSearch`	1.7MB	1.7MB	+97.0B
total			⚠️ +2.3MB

Distributable file count

id	before	after	diff
`default`	46948	47722	+774

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`apm`	48.8KB	48.8KB	+8.0B
`upgradeAssistant`	60.4KB	60.5KB	+97.0B
total			+105.0B

Unknown metric groups

@kbn/ui-shared-deps asset size

id	before	after	diff
`kbn-ui-shared-deps.@elastic.js`	3.2MB	2.4MB	-765.1KB
`kbn-ui-shared-deps.js`	13.5MB	14.3MB	⚠️ +812.9KB
total			+47.8KB

History

💚 Build #92730 succeeded a9608b7
💔 Build #92540 failed 9ac95d8
💔 Build #92516 failed 737e88d
💔 Build #92463 failed 40ff9ee
💔 Build #90541 failed 1e7c7d1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…k-field-to-hot-phase * 'master' of github.com:elastic/kibana: (429 commits) simplify popover open state logic (elastic#85379) [Logs UI][Metrics UI] Move actions to the kibana header (elastic#84648) [Search Source] Do not pick scripted fields if * provided (elastic#85133) [Search] Session SO polling (elastic#84225) [Transform] Replace legacy elasticsearch client (elastic#84932) [Uptime]Refactor header and action menu (elastic#83779) Fix agg select external link (elastic#85380) [ILM] Show forcemerge in hot when rollover is searchable snapshot is enabled (elastic#85292) clear using keyboard (elastic#85042) [GS] add tag and dashboard suggestion results (elastic#85144) [ML] API integration tests - skip GetAnomaliesTableData Add ECS field for event.code. (elastic#85109) [Functional][TSVB] Wait for markdown textarea to be cleaned (elastic#85128) skip flaky suite (elastic#62060) skip flaky suite (elastic#85098) Bump highlight.js to v9.18.5 (elastic#84296) Add `server.publicBaseUrl` config (elastic#85075) [Alerting & Actions ] More debug logging (elastic#85149) [Security Solution][Case] Manual attach alert to a case (elastic#82996) Loosen UUID regex to accept uuidv1 or uuidv4 (elastic#85338) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase/warm_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts # x-pack/plugins/index_lifecycle_management/server/routes/api/policies/register_create_route.ts

kibanamachine · 2020-12-10T03:04:39Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2020-12-11T03:14:39Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2020-12-14T03:24:39Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

dependabot bot added the dependencies Pull requests that update a dependency file label Nov 25, 2020

kibanamachine added 💝community and removed dependencies Pull requests that update a dependency file labels Nov 25, 2020

jportner self-assigned this Nov 25, 2020

jportner added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Nov 25, 2020

jportner added 2 commits November 25, 2020 17:27

Revert "Bump highlight.js from 9.15.10 to 10.1.2"

082fb45

This reverts commit 929c766.

Bump all highlight.js dependencies to version 9.18.5

ffe06e4

Includes transitive dependencies.

jportner requested a review from watson November 25, 2020 22:41

jportner added v7.10.1 v7.11.0 and removed backport:skip This commit does not require backporting labels Nov 25, 2020

watson changed the title ~~Bump highlight.js from 9.15.10 to 10.1.2~~ Bump highlight.js to v9.18.5 Nov 26, 2020

This comment has been minimized.

Sign in to view

Merge branch 'master' into dependabot/npm_and_yarn/highlight.js-10.1.2

1e7c7d1

This comment has been minimized.

Sign in to view

jportner added v7.10.2 and removed v7.10.1 labels Nov 30, 2020

Merge branch 'master' into dependabot/npm_and_yarn/highlight.js-10.1.2

40ff9ee

Fix errors

52697fc

Had to upgrade react-syntax-highlighter too. Fingers crossed.

dependabot bot requested a review from a team as a code owner December 7, 2020 20:17

botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 7, 2020

jportner reviewed Dec 7, 2020

View reviewed changes

Bump lowlight

9ac95d8

sorenlouv reviewed Dec 8, 2020

View reviewed changes

Merge branch 'master' into dependabot/npm_and_yarn/highlight.js-10.1.2

a9608b7

watson approved these changes Dec 8, 2020

View reviewed changes

sorenlouv approved these changes Dec 8, 2020

View reviewed changes

Fix line break rendering

2be72fa

The old version of react-syntax-highlighter would ignore newline characters. This version renders them in the DOM instead. I had to update a component to remove newline characters from the ends of line strings so they would render as expected.

sorenlouv mentioned this pull request Dec 8, 2020

[APM] react-syntax-highlighter has started to treat linebreaks differently #85356

Closed

2 tasks

jportner merged commit 176d7e4 into master Dec 9, 2020

jportner deleted the dependabot/npm_and_yarn/highlight.js-10.1.2 branch December 9, 2020 03:02

jportner added the backport pending label Dec 9, 2020

This was referenced Dec 9, 2020

[7.x] Bump highlight.js to v9.18.5 (#84296) #85368

Merged

[7.10] Bump highlight.js to v9.18.5 (#84296) #85369

Merged

jportner added a commit to jportner/kibana that referenced this pull request Dec 9, 2020

Bump highlight.js to v9.18.5 (elastic#84296)

524eeb0

jportner added a commit that referenced this pull request Dec 9, 2020

Bump highlight.js to v9.18.5 (#84296) (#85368)

f42f7e9

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 10, 2020

jportner added a commit to jportner/kibana that referenced this pull request Dec 14, 2020

Bump highlight.js to v9.18.5 (elastic#84296)

1b0c635

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 15, 2020

jportner added a commit that referenced this pull request Dec 15, 2020

[7.10] Bump highlight.js to v9.18.5 (#84296) (#85369)

6f7ab30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump highlight.js to v9.18.5 #84296

Bump highlight.js to v9.18.5 #84296

dependabot bot commented on behalf of github Nov 25, 2020

kibanamachine commented Nov 25, 2020

jportner commented Nov 25, 2020

watson commented Nov 26, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jportner commented Dec 7, 2020

jportner left a comment

jportner Dec 7, 2020

jportner Dec 7, 2020

jportner Dec 7, 2020

jportner commented Dec 7, 2020

sorenlouv Dec 8, 2020

jportner Dec 8, 2020 •

edited

Loading

jportner commented Dec 8, 2020

jportner commented Dec 8, 2020

jportner commented Dec 8, 2020

watson left a comment •

edited

Loading

sorenlouv commented Dec 8, 2020 •

edited

Loading

jportner commented Dec 8, 2020

kibanamachine commented Dec 8, 2020

@kbn/ui-shared-deps asset size

kibanamachine commented Dec 10, 2020

kibanamachine commented Dec 11, 2020

kibanamachine commented Dec 14, 2020

		"react-syntax-highlighter": "^5.7.0",
		"react-syntax-highlighter": "^15.3.1",

Bump highlight.js to v9.18.5 #84296

Bump highlight.js to v9.18.5 #84296

Conversation

dependabot bot commented on behalf of github Nov 25, 2020

10.1.2

10.1.1

10.1.0

10.0.2

10.0.1

10.0.0

Breaking Changes

Core highlight.js lib on the client (with no extra CDN languages)

Version 10.1.2

Version 10.1.1

Version 10.1.0

kibanamachine commented Nov 25, 2020

jportner commented Nov 25, 2020

watson commented Nov 26, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jportner commented Dec 7, 2020

jportner left a comment

Choose a reason for hiding this comment

jportner Dec 7, 2020

Choose a reason for hiding this comment

jportner Dec 7, 2020

Choose a reason for hiding this comment

jportner Dec 7, 2020

Choose a reason for hiding this comment

jportner commented Dec 7, 2020

sorenlouv Dec 8, 2020

Choose a reason for hiding this comment

jportner Dec 8, 2020 • edited Loading

Choose a reason for hiding this comment

jportner commented Dec 8, 2020

jportner commented Dec 8, 2020

jportner commented Dec 8, 2020

watson left a comment • edited Loading

Choose a reason for hiding this comment

sorenlouv commented Dec 8, 2020 • edited Loading

Before

After

jportner commented Dec 8, 2020

kibanamachine commented Dec 8, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Distributable file count

Page load bundle

@kbn/ui-shared-deps asset size

History

kibanamachine commented Dec 10, 2020

kibanamachine commented Dec 11, 2020

kibanamachine commented Dec 14, 2020

jportner Dec 8, 2020 •

edited

Loading

watson left a comment •

edited

Loading

sorenlouv commented Dec 8, 2020 •

edited

Loading