Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add ignore_unavailable to avoid querying closed indices #84813

Merged
merged 5 commits into from Dec 7, 2020
Merged

[APM] Add ignore_unavailable to avoid querying closed indices #84813

merged 5 commits into from Dec 7, 2020

Conversation

sorenlouv
Copy link
Member

Closes #84212

@sorenlouv sorenlouv requested a review from a team as a code owner December 2, 2020 18:47
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv changed the title [APM] Add ignore_unavailable to all APM requests [APM] Add ignore_unavailable to avoid querying closed indices Dec 2, 2020
@dgieselaar
Copy link
Member

@sqren We might want to consider doing this for telemetry, alerting and machine learning as well.

@sorenlouv
Copy link
Member Author

I can add it to alerting. I don't think this is high priority for telemetry though. And for ML, wouldn't that be something they'd handle?

@dgieselaar
Copy link
Member

@sqren IIRC the datafeed has ignore_unavailable:false and I thought it was configurable, but not sure if we can do that (or even if we should). Just doing it for alerting sounds reasonable.

dgieselaar
dgieselaar approved these changes Dec 6, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change with the alerting ES client (and it being typed) 👍🏻

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 46920 47681 +761

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit e0d07c2 into elastic:master Dec 7, 2020
@sorenlouv sorenlouv deleted the add-ignore_unavailable-flag branch December 7, 2020 14:43
@sorenlouv sorenlouv mentioned this pull request Dec 7, 2020
Merged
sorenlouv added a commit that referenced this pull request Dec 8, 2020
@sorenlouv
[7.x] [APM] Add ignore_unavailable to avoid querying closed indices (…
8b76370 
…#84813) (#85141)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
release_note:deprecation release_note:enhancement Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Querying a closed index causes APM endpoint to throw
4 participants
@sorenlouv @elasticmachine @dgieselaar @kibanamachine