Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Allow to edit package policy with input level template #85277

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Dec 8, 2020

Summary

Resolve #85188
Introduced here #83878

It's currently not possible to edit and save an integration with a input level template

Screen Shot 2020-12-08 at 9 04 14 AM

This PR fix that by omitting the property compiled_input while sending an input, like we do for compiled_stream

How to test

  • add the "Input level templates integration" to a policy
  • try to edit that package policy

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 labels Dec 8, 2020
@nchaulet nchaulet requested a review from a team December 8, 2020 14:12
@nchaulet nchaulet self-assigned this Dec 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet nchaulet requested a review from skh December 8, 2020 15:16
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.1MB 1.1MB +52.0B

Distributable file count

id before after diff
default 46948 47708 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit a264038 into elastic:master Dec 9, 2020
@nchaulet nchaulet deleted the feature-fix-edit-input-level-template branch December 9, 2020 14:10
nchaulet added a commit to nchaulet/kibana that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Editing a package policy with a input template fail
4 participants