[Lens] Add datasource fields group help text #85544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
release_note:enhancement
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
This looks good from my perspective, but I'd like to pull in @gchaps for a second pair of eyes. |
|
LGTM |
|
@elasticmachine merge upstream |
flash1293
reviewed
Dec 14, 2020
| <strong>{label}</strong> | ||
| <p> | ||
| <strong>{label}</strong> | ||
| {!!helpTooltip && ( |
There was a problem hiding this comment.
Can we insert a blank here?
There was a problem hiding this comment.
Used some CSS rather than simple empty space to avoid space underlying:
vs
flash1293
approved these changes
Dec 14, 2020
wylieconlon
approved these changes
Dec 14, 2020
MichaelMarcialis
approved these changes
Dec 15, 2020
Comment on lines
97
to
112
| <p> | ||
| <strong className={titleClassname}>{label}</strong> | ||
| {!!helpTooltip && ( | ||
| <EuiIconTip | ||
| aria-label={helpTooltip} | ||
| type="questionInCircle" | ||
| color="subdued" | ||
| size="s" | ||
| position="right" | ||
| content={helpTooltip} | ||
| iconProps={{ | ||
| className: 'eui-alignTop', | ||
| }} | ||
| /> | ||
| )} | ||
| </p> |
There was a problem hiding this comment.
Please remove the wrapping p element. It is not necessary and it is invalid HTML5 to have it as a child of a button.
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Dec 15, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dej611
added a commit
that referenced
this pull request
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix: #83321
This PR adds some help text to explain how the criteria for the fields groups in Lens.
Checklist
Delete any items that are not applicable to this PR.