Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying the utf-8 charset when exporting aggregate tables #8662

Merged
merged 2 commits into from Oct 28, 2016

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Oct 13, 2016

This resolves the issue of opening CSVs in most applications. However, Excel 2011 for Mac lacks UTF-8 support.

Closes #8637

@kobelb
Copy link
Contributor Author

kobelb commented Oct 13, 2016

@epixa it's been requested by @LeeDr to backport this bugfix all the way back to v4.6.2. Is this appropriate for v5.0.0?

@epixa
Copy link
Contributor

epixa commented Oct 13, 2016

@kobelb @LeeDr I don't think this is appropriate for 5.0 or 4.6. It's not critical, and there is a workaround. I'd question whether we're even doing anything wrong at the moment, though I don't have any issue with us enhancing compatibility on our exported files, but that belongs in a minor release.

@epixa epixa removed the v4.6.2 label Oct 13, 2016
@LeeDr
Copy link
Contributor

LeeDr commented Oct 14, 2016

@epixa You're right in that there is a work-around. But I'd argue that its a very simple fix for a problem several people have reported and probably many more have hit but didn't report. There will be a significant number of users on Kibana 4.x for a long time.

@epixa
Copy link
Contributor

epixa commented Oct 14, 2016

@LeeDr Which can be said about most issues people encounter though, and many of those issues don't have any workaround. The only bug fixes that'll going into patch versions are critical ones.

And to be clear, I'm not convinced this is a bug at all. I'm all for improving this feature, but we're generating valid, strictly structured csv files. That Excel has a crappy default encoding setting for csv files isn't our fault, and this feature isn't an "export to Excel" feature.

The original issue was triaged as an enhancement, and I don't disagree with that assessment.

@jbudz
Copy link
Member

jbudz commented Oct 17, 2016

LGTM

@kobelb kobelb merged commit 62d40bc into elastic:master Oct 28, 2016
elastic-jasper added a commit that referenced this pull request Oct 28, 2016
---------

**Commit 1:**
Specifying the utf-8 charset when exporting aggregate tables

* Original sha: 729bb9a
* Authored by = <brandon.kobel@elastic.co> on 2016-10-13T16:35:52Z

**Commit 2:**
Fixing test. Modified capitalization of utf8 after reading W3C spec

* Original sha: ee22983
* Authored by = <brandon.kobel@elastic.co> on 2016-10-13T16:59:14Z
kobelb pushed a commit that referenced this pull request Oct 28, 2016
…ng aggregate tables

---------

**Commit 1:**
Specifying the utf-8 charset when exporting aggregate tables

* Original sha: 729bb9a
* Authored by = <brandon.kobel@elastic.co> on 2016-10-13T16:35:52Z

**Commit 2:**
Fixing test. Modified capitalization of utf8 after reading W3C spec

* Original sha: ee22983
* Authored by = <brandon.kobel@elastic.co> on 2016-10-13T16:59:14Z
nreese pushed a commit to nreese/kibana that referenced this pull request Nov 10, 2016
…#8662)

* Specifying the utf-8 charset when exporting aggregate tables
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
…t when exporting aggregate tables

---------

**Commit 1:**
Specifying the utf-8 charset when exporting aggregate tables

* Original sha: 729bb9a
* Authored by = <brandon.kobel@elastic.co> on 2016-10-13T16:35:52Z

**Commit 2:**
Fixing test. Modified capitalization of utf8 after reading W3C spec

* Original sha: ee22983
* Authored by = <brandon.kobel@elastic.co> on 2016-10-13T16:59:14Z

Former-commit-id: 8d26546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UTF8 BOM to csv export files
5 participants