[ML] Fix cloning of partition field in per-partition categorization jobs #86635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
|
Pinging @elastic/ml-ui (:ml) |
.../plugins/ml/public/application/jobs/new_job/common/job_creator/categorization_job_creator.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
qn895
approved these changes
Dec 21, 2020
|
Code LGTM 🎉 |
jgowdyelastic
deleted the
fix-cloning-of-partition-field-in-per-partition-categorzation-jobs
branch
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Dec 21, 2020
…obs (elastic#86635) * [ML] Fix cloning of partition field in per-partition categorization jobs * fixing cloned bucket span
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Dec 21, 2020
…obs (elastic#86635) * [ML] Fix cloning of partition field in per-partition categorization jobs * fixing cloned bucket span
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloning a per-partition categorisation job, the partition field is now correctly copied over.
Also fixes an issue in the categorisation wizard where switching off per-partition categorisation would not wipe the partition field.
Fixes #86279