Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana Globalization - Phase 2 #8766

Merged
merged 18 commits into from
Mar 20, 2017
Merged

Kibana Globalization - Phase 2 #8766

merged 18 commits into from
Mar 20, 2017

Commits on Mar 6, 2017

  1. Add boilerplate plugin

    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    9ac0878 View commit details
    Browse the repository at this point in the history

  2. Load translations on the client side 

    Translations need to be loaded on the client side so that they can be used the
globalization frameworks like 'angular-translate'. This translations are made
available by embedding the translations in the initial HTML payload.
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    1f84e57 View commit details
    Browse the repository at this point in the history

  3. Update translation plugin template for the change in how translations… 

    … are published
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    d2fc0c4 View commit details
    Browse the repository at this point in the history

  4. Add angular-translate as the Angular globalization framework 

    The angular-translate framework integrates with the Kibana i18n engine whereby it
consumes translations from the i18n engine and not the translations directly.
This is achieved by using a custom loader which calls the client side getTranslations()
method. This method return the translations loaded by the i18n engine during instantation
of Kibana server instance.
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    0ab48f0 View commit details
    Browse the repository at this point in the history

  5. Extract translation strings from the index pattern create page into t… 

    …ranslation file

This commit is where the strings are now localized for this page and therefore will be loaded by
the Angular globalization framework. It also associates a translation ID to each string block and
therefore enables translation of the strings into different languages. It also provides the
pattern for localizing other pages in the UI.
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    959c7ed View commit details
    Browse the repository at this point in the history

  6. Add Kibana translation documentation

    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    5317e6e View commit details
    Browse the repository at this point in the history

  7. Update "translate" tag syntax 

    - use translate directive in HTML attribute instead of body for variable replacement
    @jlo @hickeyma
    jlo authored and hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    68202d9 View commit details
    Browse the repository at this point in the history

  8. Fix syntax error in create view

    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    165d4cd View commit details
    Browse the repository at this point in the history

  9. Add new translation key pattern to verify task

    @jlo @hickeyma
    jlo authored and hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    13cfd15 View commit details
    Browse the repository at this point in the history

  10. Update the translation verification to handle separate translation pa… 

    …tterns
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    48e1ecd View commit details
    Browse the repository at this point in the history

  11. Update after review 

    Updates after review comments: elastic#8766 (review)
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    afee6d9 View commit details
    Browse the repository at this point in the history

  12. Update internationalization documentation

    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    177408e View commit details
    Browse the repository at this point in the history

  13. [test] call $timeout.flush() before debounce tests 

    * Otherwise, the '$http GET' to fetch translation resources
shows up as a deferred task here.

* Referenced from:
srl295@5d9959c
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    4dbf3a0 View commit details
    Browse the repository at this point in the history

  14. Update after review 

    Updates following review comments:
elastic#8766 (review)
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    c2438de View commit details
    Browse the repository at this point in the history

  15. Merge extract and verify translation build tasks into one task

    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    622802c View commit details
    Browse the repository at this point in the history

  16. Update document after new changes for js and info string translations

    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    2f269f8 View commit details
    Browse the repository at this point in the history

  17. Update after review 

    Update the following review comments:
elastic#8766 (review)
elastic#8766 (review)
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    5e94886 View commit details
    Browse the repository at this point in the history

  18. Replace the translation string with the translation IDs in index crea… 

    …te pattern view
    @hickeyma
    hickeyma committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    fb8dffb View commit details
    Browse the repository at this point in the history