New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Support geometry-collection #87867
[Maps] Support geometry-collection #87867
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
x-pack/plugins/maps/common/elasticsearch_util/elasticsearch_geo_utils.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/common/elasticsearch_util/elasticsearch_geo_utils.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
code review
Hi @thomasneirynck! Great work! Will this be fixed in v7.12? If yes, when will this released? I saw here the last release was v7.10.2. Thank you very much! |
@florinvirdol yes, this will be scheduled for v7.12. There's no specific release date for this at this point. And you're right, before that there will be a release of v7.11 :) |
💔 Build Failed
Failed CI Steps
Test FailuresX-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/add_actions·ts.detection engine api security and spaces enabled add_actions adding actions should be able to create a new webhook action and attach it to a ruleStandard Out
Stack Trace
X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/add_actions·ts.detection engine api security and spaces enabled add_actions adding actions should be able to create a new webhook action and attach it to a ruleStandard Out
Stack Trace
Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/home_page·ts.Actions and Triggers app Home page Alerts tab navigates to an alert details pageStandard Out
Stack Trace
and 4 more failures, only showing the first 3. Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Closes #87578
This creates a new feature for each constituent in the collection. This is necessary so the split between how points and polygon/lines are handled in Maps remains preserved (e.g. wrt. point-icon labeling or outline/fill styling). This also will label each constituent geometry separately.
To test:
In dev-tools:
Then create an index pattern and add as layer:
Checklist
Delete any items that are not applicable to this PR.
For maintainers