[ML] Data Frame Analytics: Adds scatterplot matrix to regression/classification results pages. #88353

walterra · 2021-01-14T15:58:13Z

Review note for Kibana Design Team: The github review assignment got triggered by a SCSS file rename.

Summary

Part of #84420

Adds support for scatterplot matrices to regression/classification results pages
Lazy loads the scatterplot matrix including Vega code using Suspense. The approach is taken from the Kibana Vega plugin, creating this separate bundle means you'll load the 600kb+ Vega code only on pages where actually needed and not e.g. already on the analytics job list. Note for reviews: The file scatterplot_matrix_view.tsx did not change besides the default export, it just shows up as a new file because of the refactoring to support lazy loading.
Adds support for analytics configuration that use the excludes instead of includes field list.
Adds the field used for color legends to tooltips.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

kertal · 2021-01-15T14:29:36Z

randomly clicked here, so here is just a mini review: looks very nice!

elasticmachine · 2021-01-25T11:40:40Z

Pinging @elastic/ml-ui (:ml)

pheyos

Functional tests LGTM, great to have them in as part of this PR 🎉

x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix_view.tsx

peteharverson

Tested and overall looks good. Only issue I found was that the page query isn't being used - which also applies for outlier jobs.

Not for this PR, but with the extra components being added to this views, we're almost at a point where we need to consider some sort of 'jump to' type links.

qn895 · 2021-01-26T18:54:18Z

x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix_view.tsx

+          setIsLoading(false);
+        }
+      } catch (e) {
+        // TODO error handling


Is this todo for a follow up?

Yes, it just shows up as a new line because the file was moved and git didn't recognize it was a move. Better error handling is in the list of follow ups in the meta issue here #84420

qn895 · 2021-01-26T21:33:56Z

x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix_view.tsx

+            </EuiFlexItem>
+            <EuiFlexItem style={{ width: '200px' }} grow={false}>
+              <EuiFormRow
+                label={i18n.translate('xpack.ml.splom.SampleSizeLabel', {


nit: Sample is capitalized here

Fixed in 1ab0754.

qn895 · 2021-01-26T21:34:24Z

x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix_view.tsx

+            </EuiFlexItem>
+            <EuiFlexItem style={{ width: '120px' }} grow={false}>
+              <EuiFormRow
+                label={i18n.translate('xpack.ml.splom.RandomScoringLabel', {


nit: Random is capitalized here

Fixed in 1ab0754.

qn895 · 2021-01-27T00:00:37Z

Gave this a good test and was able to reproduce Pete's problem where the query or the Training/Test groups were not updating the plots.

Also, just wondering if we modify the colors to be more contrasting, specifically for binary classification analytics. For example, the current order makes it harder to distinguish yes or no in the charts since the two first colors are so similar.

Another option is to make the colors bolder, like what we have with the Elastic charts.

Another minor one which I'm pretty sure is not due to your PR, when the div overflows, for some reason on Chrome-based browsers the scroll bar is black:

walterra · 2021-01-27T16:56:53Z

@peteharverson @qn895

Pushed a fix to apply the query from the search bar on all pages (wizard, outlier/regression/classification results).
Added a note to the meta issue to improve the color legend with more contrast for a follow up [ML] Data Frame Analytics: Scatterplot Matrix #84420

peteharverson

Tested latest edits and LGTM

qn895 · 2021-01-27T20:10:27Z

Also tested and LGTM 🎉

walterra · 2021-02-01T09:49:08Z

@elasticmachine merge upstream

kibanamachine · 2021-02-01T11:29:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b0df644

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1730	1734	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	6.5MB	6.6MB	+8.7KB

Unknown metric groups

async chunk count

id	before	after	diff
`ml`	19	20	+1

History

💚 Build #101431 succeeded eadbe82
💚 Build #100615 succeeded 3e81233
💔 Build #100389 failed 73b7419
💔 Build #100370 failed 7910a7f
💚 Build #100279 succeeded ce8d200

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…sification results pages. (elastic#88353) - Adds support for scatterplot matrices to regression/classification results pages - Lazy loads the scatterplot matrix including Vega code using Suspense. The approach is taken from the Kibana Vega plugin, creating this separate bundle means you'll load the 600kb+ Vega code only on pages where actually needed and not e.g. already on the analytics job list. Note for reviews: The file scatterplot_matrix_view.tsx did not change besides the default export, it just shows up as a new file because of the refactoring to support lazy loading. - Adds support for analytics configuration that use the excludes instead of includes field list. - Adds the field used for color legends to tooltips.

…sification results pages. (#88353) (#89848) - Adds support for scatterplot matrices to regression/classification results pages - Lazy loads the scatterplot matrix including Vega code using Suspense. The approach is taken from the Kibana Vega plugin, creating this separate bundle means you'll load the 600kb+ Vega code only on pages where actually needed and not e.g. already on the analytics job list. Note for reviews: The file scatterplot_matrix_view.tsx did not change besides the default export, it just shows up as a new file because of the refactoring to support lazy loading. - Adds support for analytics configuration that use the excludes instead of includes field list. - Adds the field used for color legends to tooltips.

walterra added release_note:enhancement :ml v8.0.0 Feature:Data Frame Analytics ML data frame analytics features v7.12.0 labels Jan 14, 2021

walterra self-assigned this Jan 14, 2021

This was referenced Jan 20, 2021

[ML] Data Frame Analytics: Scatterplot Matrix #84420

Open

[ML] Increase Test Coverage 7.12 #88811

Closed

walterra added 5 commits January 25, 2021 10:11

[ML] Adds scatterplot matrix to regression/classification results pages.

f78735a

[ML] Fix missing export.

e2d3b04

[ML] Lazy loading.

d1e4131

[ML] Add color field to tooltip. Add support for jobs not using include.

4dd9334

[ML] Functional Tests.

3e81233

walterra force-pushed the ml-scatterplot-results-pages branch from 73b7419 to 3e81233 Compare January 25, 2021 09:17

walterra requested a review from pheyos January 25, 2021 11:39

walterra marked this pull request as ready for review January 25, 2021 11:40

walterra requested review from a team as code owners January 25, 2021 11:40

walterra requested review from peteharverson and qn895 January 25, 2021 12:02

pheyos approved these changes Jan 26, 2021

View reviewed changes

peteharverson reviewed Jan 26, 2021

View reviewed changes

x-pack/plugins/ml/public/application/components/scatterplot_matrix/scatterplot_matrix_view.tsx Show resolved Hide resolved

peteharverson reviewed Jan 26, 2021

View reviewed changes

ryankeairns approved these changes Jan 26, 2021

View reviewed changes

qn895 reviewed Jan 26, 2021

View reviewed changes

walterra added 3 commits January 27, 2021 10:41

[ML] Apply query bar query to scatterplot matrix.

535cd0b

[ML] Fix translations.

1ab0754

Merge branch 'master' into ml-scatterplot-results-pages

eadbe82

peteharverson approved these changes Jan 27, 2021

View reviewed changes

qn895 approved these changes Jan 27, 2021

View reviewed changes

Merge branch 'master' into ml-scatterplot-results-pages

b0df644

walterra merged commit fb19aab into elastic:master Feb 1, 2021

walterra deleted the ml-scatterplot-results-pages branch February 1, 2021 11:31

walterra mentioned this pull request Feb 1, 2021

[7.x] [ML] Data Frame Analytics: Adds scatterplot matrix to regression/classification results pages. (#88353) #89848

Merged

lcawl added the release_note:feature Makes this part of the condensed release notes label Feb 5, 2021

lcawl mentioned this pull request Feb 24, 2021

[DOCS] Adds scatterplot matrix to regression and classification results elastic/stack-docs#1592

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Data Frame Analytics: Adds scatterplot matrix to regression/classification results pages. #88353

[ML] Data Frame Analytics: Adds scatterplot matrix to regression/classification results pages. #88353

walterra commented Jan 14, 2021 •

edited

Loading

kertal commented Jan 15, 2021

elasticmachine commented Jan 25, 2021

pheyos left a comment

peteharverson left a comment

qn895 Jan 26, 2021

walterra Jan 27, 2021

qn895 Jan 26, 2021

walterra Jan 27, 2021

qn895 Jan 26, 2021

walterra Jan 27, 2021

qn895 commented Jan 27, 2021 •

edited

Loading

walterra commented Jan 27, 2021

peteharverson left a comment

qn895 commented Jan 27, 2021

walterra commented Feb 1, 2021

kibanamachine commented Feb 1, 2021

async chunk count

[ML] Data Frame Analytics: Adds scatterplot matrix to regression/classification results pages. #88353

[ML] Data Frame Analytics: Adds scatterplot matrix to regression/classification results pages. #88353

Conversation

walterra commented Jan 14, 2021 • edited Loading

Summary

Checklist

For maintainers

kertal commented Jan 15, 2021

elasticmachine commented Jan 25, 2021

pheyos left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

qn895 Jan 26, 2021

Choose a reason for hiding this comment

walterra Jan 27, 2021

Choose a reason for hiding this comment

qn895 Jan 26, 2021

Choose a reason for hiding this comment

walterra Jan 27, 2021

Choose a reason for hiding this comment

qn895 Jan 26, 2021

Choose a reason for hiding this comment

walterra Jan 27, 2021

Choose a reason for hiding this comment

qn895 commented Jan 27, 2021 • edited Loading

walterra commented Jan 27, 2021

peteharverson left a comment

Choose a reason for hiding this comment

qn895 commented Jan 27, 2021

walterra commented Feb 1, 2021

kibanamachine commented Feb 1, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

async chunk count

History

walterra commented Jan 14, 2021 •

edited

Loading

qn895 commented Jan 27, 2021 •

edited

Loading