Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent autocompleting the username field #88682

Merged
merged 6 commits into from Feb 1, 2021
Merged

Prevent autocompleting the username field #88682

merged 6 commits into from Feb 1, 2021

Conversation

legrego
Copy link
Member

@legrego legrego commented Jan 19, 2021 •
edited

Summary

Prevents the username field on the login screen from offering autocomplete suggestions.

We haven't committed to moving forward with this yet, but opening up for review anyway.

@legrego legrego added reason:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.12.0 v8.0.0 labels Jan 19, 2021
@legrego legrego marked this pull request as ready for review January 19, 2021 18:03
@legrego legrego requested a review from a team as a code owner January 19, 2021 18:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

jportner
jportner approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jportner
Copy link
Contributor

@elasticmachine merge upstream

@legrego
Copy link
Member Author

legrego commented Jan 20, 2021

@elasticmachine merge upstream

@legrego
Copy link
Member Author

legrego commented Jan 29, 2021

@elasticmachine merge upstream

@legrego
Copy link
Member Author

legrego commented Feb 1, 2021

@elasticmachine merge upstream

@legrego
Copy link
Member Author

legrego commented Feb 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 724.2KB 724.2KB +19.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego merged commit 7b06c13 into elastic:master Feb 1, 2021
@legrego legrego deleted the security/disable-username-autocomplete branch February 1, 2021 20:31
@legrego legrego added the v7.11.1 label Feb 1, 2021
This was referenced Feb 1, 2021
Merged
Merged
legrego added a commit to legrego/kibana that referenced this pull request Feb 1, 2021
@legrego @kibanamachine
Prevent autocompleting the username field (elastic#88682)
a4e82fa 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
legrego added a commit to legrego/kibana that referenced this pull request Feb 1, 2021
@legrego @kibanamachine
Prevent autocompleting the username field (elastic#88682)
a71514c 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Feb 1, 2021
@legrego
Prevent autocompleting the username field (#88682) (#89924)
1860d6e
legrego added a commit that referenced this pull request Feb 1, 2021
@legrego
Prevent autocompleting the username field (#88682) (#89926)
2231bf2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legrego @elasticmachine @jportner @kibanamachine