Toggling spy panel no longer throws an error #8877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
requested changes
Oct 29, 2016
There was a problem hiding this comment.
i might be wrong but this seems wrong :) so in dispatch you now always overwrite handler.highlight function with dispatch.highlight .... you defined default noop functions on handler, but those will always get overwriten by dispatch.highligh
| if (!this.handler.highlight) { | ||
| this.handler.highlight = self.highlight; | ||
| } | ||
| this.handler.highlight = self.highlight; |
There was a problem hiding this comment.
so you are always overwriting handler.highlight, even if its already defined. when area chart defines highlight function on handler it will be ignored .... (overwriten by dispatch.highlight)
There was a problem hiding this comment.
great, thanks for flagging this. you're right, this is not going to work since we're also overriding in other places.
thomasneirynck
force-pushed
the
fix/8869
branch
from
1a5f60b
to
6fad2be
Compare
|
LGTM, as discussed this is temporary till the vislib rewrite is merged. |
ppisljar
approved these changes
Oct 31, 2016
jbudz
approved these changes
Oct 31, 2016
elastic-jasper
added a commit
that referenced
this pull request
Oct 31, 2016
Backports PR #8877 **Commit 1:** Toggling spy panel no longer throws an error * Original sha: 0de553d * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-28T18:06:05Z **Commit 2:** Complete existence check before using handler * Original sha: 6fad2be * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-31T14:11:40Z
This was referenced Oct 31, 2016
elastic-jasper
added a commit
that referenced
this pull request
Oct 31, 2016
Backports PR #8877 **Commit 1:** Toggling spy panel no longer throws an error * Original sha: 0de553d * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-28T18:06:05Z **Commit 2:** Complete existence check before using handler * Original sha: 6fad2be * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-31T14:11:40Z
thomasneirynck
pushed a commit
that referenced
this pull request
Nov 1, 2016
Backports PR #8877 **Commit 1:** Toggling spy panel no longer throws an error * Original sha: 0de553d * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-28T18:06:05Z **Commit 2:** Complete existence check before using handler * Original sha: 6fad2be * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-31T14:11:40Z
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 10, 2016
Complete existence check of highlight-handler, before using it
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#8877 **Commit 1:** Toggling spy panel no longer throws an error * Original sha: 0de553d * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-28T18:06:05Z **Commit 2:** Complete existence check before using handler * Original sha: 6fad2be * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-10-31T14:11:40Z Former-commit-id: c834ee7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8869.
Also tidied up some linter warnings.