[functional_cors] use pre-defined unique port in CI #88919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
removed
the
Team:Core
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
This was referenced Jan 21, 2021
spalger
added a commit
to spalger/kibana
that referenced
this pull request
Jan 21, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger
added a commit
that referenced
this pull request
Jan 21, 2021
spalger
added a commit
that referenced
this pull request
Jan 21, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functional_cors suite currently uses the
get-portmodule to pick a random port. This seems to have race condition issues which cause the port to sometimes be used by another server, example: https://kibana-ci.elastic.co/job/elastic+kibana+7.x/11174/execution/node/670/log/?consoleFullI previously tried to fix this by removing the
defaultoption in #87050This doesn't seem to have prevented the issue, so instead we will detect when the tests are running on CI and explicitly set the port via the Jenkinsfile.