Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Uptime] Migrate to TypeScript project references (#90510) #90721

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

justinkambic
Copy link
Contributor

Backports the following commits to 7.x:

* Add reference to Uptime plugin to root tsconfig.refs.json.

* Add Uptime path to excluded list, and reference to references prop in `x-pack/tsconfig.json`.

* Add reference to Uptime project in `x-pack/test/tsconfig.json`.

* Add `tsconfig.json` project file to Uptime.

* Fix broken JSON structure in test fixture.

* Fix broken type exports. Introduce missing types.

* Implement PR feedback.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@justinkambic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 581 582 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 895.8KB 896.4KB +592.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uptime 19.3KB 19.4KB +90.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic justinkambic self-assigned this Feb 9, 2021
@justinkambic justinkambic added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0 labels Feb 9, 2021
@justinkambic justinkambic merged commit c8b1485 into elastic:7.x Feb 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic deleted the backport/7.x/pr-90510 branch February 9, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants