[TSVB] Fixes the timeseries legend, renders the metric, gauge charts for series with empty strings #90760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
stratoula
changed the title
stratoula
changed the title
stratoula
changed the title
stratoula
changed the title
|
@elasticmachine merge upstream |
stratoula
added
Feature:TSVB
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
mbondyra
approved these changes
Feb 16, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Feb 16, 2021
…for series with empty strings (elastic#90760) * [TSVB] Fixes the legend for empty values and renders the metric, gauge charts * Change i18n id Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Feb 16, 2021
…for series with empty strings (#90760) (#91468) * [TSVB] Fixes the legend for empty values and renders the metric, gauge charts * Change i18n id Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #90758
It seems that TSVB charts do not treat correctly series with empty strings. Specifically, timeseries render the chart but not the legend, metric and gauge charts for the empty string is not rendered at all and table and TopN are rendered but without a label. So I followed the Lens logic and applied the
(empty)string here.Timeseries with empty label
Render the metric and gauge for the empty label
Table with empty label
TopN
Checklist