Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error.stack_trace to the default log formatter #94906

Merged
merged 3 commits into from Mar 26, 2021

Conversation

felixbarny
Copy link
Member

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.
Closes #46211

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@felixbarny felixbarny added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Mar 18, 2021
@felixbarny
Copy link
Member Author

I hit an issue when testing this change: in the default mapping for error.stack_trace, the field is not indexed. See https://github.com/elastic/ecs/blob/fd9917931f87ac7243149190953ffdd5ea8bbf2a/schemas/error.yml#L39-L47

So we could either try using error.stack_trace.text or make the logs UI retrieve the fields from _source. I'll try the first option for now as it's easier to test.

@felixbarny
Copy link
Member Author

felixbarny commented Mar 18, 2021

With error.stack_trace.text, it's now working nicely 🙂

Screen Shot 2021-03-18 at 18 12 02

@felixbarny felixbarny marked this pull request as ready for review March 18, 2021 17:13
@felixbarny felixbarny requested a review from a team as a code owner March 18, 2021 17:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixbarny Thanks for this, it looks to work well 🎉

Screenshot 2021-03-26 at 13 17 18

@felixbarny felixbarny added auto-backport Deprecated: Automatically backport this PR after it's merged v7.13.0 release_note:enhancement labels Mar 26, 2021
@felixbarny
Copy link
Member Author

@elasticmachine merge upstream

@felixbarny felixbarny enabled auto-merge (squash) March 26, 2021 13:57
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #95544

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 26, 2021
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
@felixbarny felixbarny deleted the logs-ui-stack_trace branch March 27, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Logs UI Logs UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs UI] Support error.stack_trace
4 participants