Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View/edit mode for dashboards #9508

Closed
wants to merge 23 commits into from
Closed

View/edit mode for dashboards #9508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
506734c
View edit mode
stacey-gammon Dec 15, 2016
512a21b
Add confirmation for switching restoring dashboard default filters
stacey-gammon Jan 16, 2017
a40dc02
fix handling of new dashboards
stacey-gammon Jan 16, 2017
5d664b6
Add help text for empty dashboard in view mode
stacey-gammon Jan 16, 2017
496feb3
Track changes to time filter manually
stacey-gammon Jan 16, 2017
4668e7e
Introduce custom modal confirmation dialogs
stacey-gammon Jan 13, 2017
c9840ef
address code review comments
stacey-gammon Jan 13, 2017
c4b4339
refactor
w33ble Jan 14, 2017
7ab784e
Clean up from merge
stacey-gammon Jan 16, 2017
cf3abc2
Fix tests
stacey-gammon Jan 16, 2017
58b0174
Use ui-framework styles
stacey-gammon Jan 17, 2017
b423dbc
incorporate new modal dialogs
stacey-gammon Jan 17, 2017
fd77a3c
Add ability to cancel out of confirm dialogs
stacey-gammon Jan 17, 2017
012667d
Bug fix and clean up dialog
stacey-gammon Jan 19, 2017
3c5e4bf
Bug fix and customize filter warning dialog
stacey-gammon Jan 19, 2017
17a130c
Merge with master
stacey-gammon Jan 19, 2017
0f8c774
Fix bug and modify unsaved changes warning
stacey-gammon Jan 19, 2017
8c8da92
Introduce dashboard landing page
stacey-gammon Jan 23, 2017
2dbfea7
use clickable breadcrumbs instead of 'New' and 'Open' nav items
stacey-gammon Jan 23, 2017
d9cf7d3
code cleanup
stacey-gammon Jan 23, 2017
410a384
Merge dashboard-landing-page
stacey-gammon Jan 23, 2017
5a1c133
Show edit style always in edit mode
stacey-gammon Jan 23, 2017
271b5e1
Use done instead of stop editing
stacey-gammon Jan 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...lugins/kibana/public/dashboard/index.html → ...ns/kibana/public/dashboard/dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
<!-- Title. -->
<div
data-transclude-slot="topLeftCorner"
class="kuiLocalTitle"
>
<span ng-bind="getDashTitle()"></span>
<!-- Breadcrumbs. -->
<bread-crumbs title="getDashTitle()" use-links="true" omit-current-page="true"></bread-crumbs>
</div>

<!-- Search. -->
Expand Down Expand Up @@ -56,12 +56,18 @@ <h2>This dashboard is empty. Let's fill it up!</h2>
<p>Click the <a class="btn btn-xs navbtn-inverse" ng-click="kbnTopNav.open('add'); toggleAddVisualization = !toggleAddVisualization" aria-label="Add visualization">Add</a> button in the menu bar above to add a visualization to the dashboard. <br/>If you haven't setup a visualization yet visit <a href="#/visualize" title="Visualize">"Visualize"</a> to create your first visualization.</p>
</div>

<div ng-show="showViewHelpText()" class="text-center start-screen">
<h2>This dashboard is empty. Let's fill it up!</h2>
<p>Click the <a class="btn btn-xs navbtn-inverse" ng-click="kbnTopNav.open('edit');" aria-label="Edit">Edit</a> button in the menu bar above to start working on your new dashboard.
</div>

<dashboard-grid ng-if="!hasExpandedPanel()"></dashboard-grid>

<dashboard-panel ng-if="hasExpandedPanel()"
panel="expandedPanel"
is-full-screen-mode="!chrome.getVisible()"
is-expanded="true"
dashboard-view-mode="dashboardViewMode"
get-vis-click-handler="filterBarClickHandler(state)"
get-vis-brush-handler="brushEvent(state)"
save-state="state.save()"
Expand Down
Loading