[Maps] fix tooltips with timestamp appear as epoch #95106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
approved these changes
Mar 23, 2021
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 23, 2021
* [Maps] fix tooltips with timestamp appear as epoch * request dates as strict_date_optional_time for tooltips
This was referenced Mar 23, 2021
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Mar 23, 2021
* [Maps] fix tooltips with timestamp appear as epoch * request dates as strict_date_optional_time for tooltips
nreese
added a commit
that referenced
this pull request
Mar 23, 2021
nreese
added a commit
that referenced
this pull request
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95072
This PR updates tooltip request to fetch date fields as strict_date_optional_time instead of epoch_millis. There is an elasticsearch bug, elastic/elasticsearch#50622, where epoch_millis returns a string instead of a number. As a result, the field formatter can not parse the value. Fetching the value as strict_date_optional_time avoids this problem.