Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections][Threshold Rules] Add threshold_result to alert notification context #95354

Merged
merged 4 commits into from
Apr 1, 2021
Merged

[Security Solution][Detections][Threshold Rules] Add threshold_result to alert notification context #95354

merged 4 commits into from
Apr 1, 2021

Conversation

madirey
Copy link
Contributor

@madirey madirey commented Mar 24, 2021 •
edited
Loading

Summary

Fixes #94699

Checklist

N/A

For maintainers

@madirey madirey added release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Detection Alerts Security Solution Detection Alerts Feature v7.12.1 labels Mar 24, 2021
@madirey madirey requested a review from a team as a code owner March 24, 2021 19:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@madirey
Copy link
Contributor Author

madirey commented Mar 24, 2021 •
edited
Loading

Fixes #94699

@madirey
Copy link
Contributor Author

madirey commented Apr 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@madirey madirey merged commit 9c5641d into elastic:master Apr 1, 2021
@madirey madirey deleted the threshold-context branch April 1, 2021 13:58
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 5, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 95354 or prevent reminders by adding the backport:skip label.

@madirey madirey mentioned this pull request Apr 6, 2021
Merged
madirey added a commit to madirey/kibana that referenced this pull request Apr 6, 2021
@madirey @kibanamachine
[Security Solution][Detections][Threshold Rules] Add `threshold_resul…
60f494b 
…t` to alert notification context (elastic#95354)

* Don't remove threshold_result from _source prematurely

* Fix type error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@madirey madirey mentioned this pull request Apr 6, 2021
Merged
madirey added a commit to madirey/kibana that referenced this pull request Apr 6, 2021
@madirey
[Security Solution][Detections][Threshold Rules] Add `threshold_resul…
61d8f62 
…t` to alert notification context (elastic#95354)

* Don't remove threshold_result from _source prematurely

* Fix type error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_bulk_body.ts
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

madirey added a commit that referenced this pull request Apr 7, 2021
@madirey @kibanamachine
[Security Solution][Detections][Threshold Rules] Add `threshold_resul…
7e03843 
…t` to alert notification context (#95354) (#96310)

* Don't remove threshold_result from _source prematurely

* Fix type error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

madirey added a commit that referenced this pull request Apr 13, 2021
@madirey @kibanamachine
[Security Solution][Detections][Threshold Rules] Add `threshold_resul…
ee2750a 
…t` to alert notification context (#95354) (#96315)

* Don't remove threshold_result from _source prematurely

* Fix type error

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_bulk_body.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees
No one assigned
Labels
Feature:Detection Alerts Security Solution Detection Alerts Feature release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.12.1 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution][Detections] Threshold signal fields are not available in Actions context
4 participants
@madirey @elasticmachine @kibanamachine @spong