Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Timeline Template README.md #95814

Merged
merged 4 commits into from May 11, 2021
Merged

Conversation

peasead
Copy link
Contributor

@peasead peasead commented Mar 30, 2021

Summary

xpack.security_solution.signalsIndex is listed to be added to kibana.dev.yml, however that generates:

FATAL  Error: Unknown configuration key(s): "xpack.security_solution.signalsIndex". \
Check for spelling errors and ensure that expected plugins are installed.

I think this should be xpack.securitySolution.signalsIndex

This is for the steps to create a timeline template.

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials

For maintainers

Update to xpack.securitySolution.signalsIndex
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Added some clarification to create the `.siem-signals-elastic-default` index or the `hard_reset` will error.
@peasead
Copy link
Contributor Author

peasead commented Apr 9, 2021

Is there anything I need to do for this?

@nastasha-solomon
Copy link
Contributor

@peasead apologies for the delayed response. Would you mind sharing where you're seeing this issue in our Security docs? I searched our docs for "xpack.security_solution.signalsIndex", "kibana.dev.yml", and variations of both but was unable to find mentions of either.
cc: @jmikell821

@peasead
Copy link
Contributor Author

peasead commented Apr 15, 2021

This is where I saw that. Is that improper? I noticed when I was trying to make a Timeline Template PR.

https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/server/lib/detection_engine/README.md

Open your kibana.dev.yml file and add these lines:
xpack.security_solution.signalsIndex: .siem-signals-${your user id}

@nastasha-solomon
Copy link
Contributor

@peasead ah ok. The readme that you shared looks like internal documentation for devs--I thought you were referring to these public-facing docs (which is what @jmikell821 and I maintain):
https://www.elastic.co/guide/en/security/master/timeline-templates-ui.html

@peasead
Copy link
Contributor Author

peasead commented Apr 21, 2021

@nastasha-solomon do you know what group I need to ping to get the right visibility on this?

@@ -35,7 +35,7 @@ source ~/.zshrc
Open your `kibana.dev.yml` file and add these lines:

```sh
xpack.security_solution.signalsIndex: .siem-signals-${your user id}
xpack.securitySolution.signalsIndex: .siem-signals-${your user id}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and updating this @peasead! 👍

@@ -46,6 +46,8 @@ server log [22:05:22.277] [info][status][plugin:alerting@8.0.0] Status changed f
server log [22:05:22.270] [info][status][plugin:actions@8.0.0] Status changed from uninitialized to green - Ready
```

Go into Kibana and load the default detection rules or manually create the `.siem-signals-elastic-default` index.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? The following step of running the hard_reset.sh script will manage creating the signals index.

# re-create the signal index
./delete_signal_index.sh
./post_signal_index.sh

@spong spong requested a review from a team April 21, 2021 17:22
@spalger spalger added v7.14.0 and removed v7.13.0 labels Apr 21, 2021
@peasead
Copy link
Contributor Author

peasead commented May 4, 2021

Is this documentation update waiting on anything from me?

@spong
Copy link
Member

spong commented May 11, 2021

Is this documentation update waiting on anything from me?

I think just the feedback around the extra step. I went ahead and updated, so this should be g2g. Approving and setting to auto-merge then. Thanks again for catching and updating this @peasead! 🙂

@spong spong enabled auto-merge (squash) May 11, 2021 02:33
@spong spong merged commit 4831826 into master May 11, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 13, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 95814 or prevent reminders by adding the backport:skip label.

@spong spong deleted the timeline-template-commit-doc-fix-1 branch May 13, 2021 14:07
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 95814 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 95814 or prevent reminders by adding the backport:skip label.

@spong spong added the auto-backport Deprecated: Automatically backport this PR after it's merged label May 17, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 17, 2021
## Summary

`xpack.security_solution.signalsIndex` is listed to be added to `kibana.dev.yml`, however that generates:
```
FATAL  Error: Unknown configuration key(s): "xpack.security_solution.signalsIndex". \
Check for spelling errors and ensure that expected plugins are installed.
```
I think this should be `xpack.securitySolution.signalsIndex`

This is for the steps to create a timeline template.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 17, 2021
kibanamachine added a commit that referenced this pull request May 17, 2021
## Summary

`xpack.security_solution.signalsIndex` is listed to be added to `kibana.dev.yml`, however that generates:
```
FATAL  Error: Unknown configuration key(s): "xpack.security_solution.signalsIndex". \
Check for spelling errors and ensure that expected plugins are installed.
```
I think this should be `xpack.securitySolution.signalsIndex`

This is for the steps to create a timeline template.

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Andrew Pease <7442091+peasead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged docs documentation release_note:fix Team:Docs v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants