[Search Sessions] fix updating deleting sessions from non-default space #96123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Dosant
added
release_note:fix
Team:AppServices
v7.12.1
v7.13.0
v8.0.0
Feature:Search
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
legrego
reviewed
Apr 2, 2021
There was a problem hiding this comment.
Changes to the logic LGTM
Can we update the unit tests in x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.test.ts to verify that we're calling the Saved Objects Client with the appropriate namespace for the update and delete operations?
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
legrego
approved these changes
Apr 5, 2021
lizozom
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 5, 2021
…ce (elastic#96123) * add spaces test * fix updating and deleting sessions in non-default space * revert back to batch update * Add space tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Liza K <liza.katz@elastic.co>
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Apr 5, 2021
…ce (elastic#96123) * add spaces test * fix updating and deleting sessions in non-default space * revert back to batch update * Add space tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Liza K <liza.katz@elastic.co> # Conflicts: # x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.ts
kibanamachine
added a commit
that referenced
this pull request
Apr 5, 2021
…ce (#96123) (#96210) * add spaces test * fix updating and deleting sessions in non-default space * revert back to batch update * Add space tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Liza K <liza.katz@elastic.co> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> Co-authored-by: Liza K <liza.katz@elastic.co>
lizozom
added a commit
that referenced
this pull request
Apr 5, 2021
…ce (#96123) (#96211) * add spaces test * fix updating and deleting sessions in non-default space * revert back to batch update * Add space tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Liza K <liza.katz@elastic.co> # Conflicts: # x-pack/plugins/data_enhanced/server/search/session/check_running_sessions.ts Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Dosant
added a commit
that referenced
this pull request
May 12, 2021
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
May 12, 2021
…lastic#99617) Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Dosant
added a commit
that referenced
this pull request
May 12, 2021
…#99965) Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Potential bare minimum fix for #96124
The problem was that updates/deletes of sessions from non-default spaces failed with
404because we were trying to update/delete them in the default space.I also improved logging a bit.
While debugging we identify other potential improvements, but they out of scope for this patch pr: #96131
Checklist
Delete any items that are not applicable to this PR.
For maintainers