-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix Fleet API integration tests #96837
[Fleet] Fix Fleet API integration tests #96837
Conversation
@elasticmachine merge upstream |
f734fa5
to
5df83ae
Compare
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green CI
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀 on 💚 CI
thanks for fixing these, @nchaulet ! |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
# Conflicts: # x-pack/scripts/functional_tests.js
## Summary Seeing failures like this locally for `x-pack/test/fleet_api_integration/apis/agents/unenroll.ts` tests <details><summary>screenshot of error</summary> <img width="1121" alt="Screen Shot 2021-04-13 at 10 06 51 AM" src="https://user-images.githubusercontent.com/57655/114592495-fec04280-9c58-11eb-939c-b84aa7469c2a.png"> </details> Copied the `esArchiver` patterns from `x-pack/test/fleet_api_integration/apis/agents/reassign.ts` in #96837 and the error is gone ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Seeing failures like this locally for `x-pack/test/fleet_api_integration/apis/agents/unenroll.ts` tests <details><summary>screenshot of error</summary> <img width="1121" alt="Screen Shot 2021-04-13 at 10 06 51 AM" src="https://user-images.githubusercontent.com/57655/114592495-fec04280-9c58-11eb-939c-b84aa7469c2a.png"> </details> Copied the `esArchiver` patterns from `x-pack/test/fleet_api_integration/apis/agents/reassign.ts` in elastic#96837 and the error is gone ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…7037) ## Summary Seeing failures like this locally for `x-pack/test/fleet_api_integration/apis/agents/unenroll.ts` tests <details><summary>screenshot of error</summary> <img width="1121" alt="Screen Shot 2021-04-13 at 10 06 51 AM" src="https://user-images.githubusercontent.com/57655/114592495-fec04280-9c58-11eb-939c-b84aa7469c2a.png"> </details> Copied the `esArchiver` patterns from `x-pack/test/fleet_api_integration/apis/agents/reassign.ts` in #96837 and the error is gone ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: John Schulz <john.schulz@elastic.co>
## Summary Seeing failures like this locally for `x-pack/test/fleet_api_integration/apis/agents/unenroll.ts` tests <details><summary>screenshot of error</summary> <img width="1121" alt="Screen Shot 2021-04-13 at 10 06 51 AM" src="https://user-images.githubusercontent.com/57655/114592495-fec04280-9c58-11eb-939c-b84aa7469c2a.png"> </details> Copied the `esArchiver` patterns from `x-pack/test/fleet_api_integration/apis/agents/reassign.ts` in elastic#96837 and the error is gone ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Summary
Resolve #96515
We broke the tests while migrating from Kibana creating the .fleet system indices to ES creating them.
that PR fix the flaky fleet API integration tests and re-enable Fleet test suite