Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.editorconfig MDX files should follow the same rules as MD #96942

Merged
merged 2 commits into from Apr 13, 2021
Merged

.editorconfig MDX files should follow the same rules as MD #96942

merged 2 commits into from Apr 13, 2021

Conversation

afharo
Copy link
Member

@afharo afharo commented Apr 13, 2021

Summary

Our eslint rules should apply to the .mdx files the same rules as we currently do to .asciidoc and .md files. Otherwise, it's breaking some intended spaces at the end of a line.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 docs labels Apr 13, 2021
@afharo afharo requested review from a team April 13, 2021 11:13
@afharo afharo mentioned this pull request Apr 13, 2021
Merged
@afharo afharo added this to Pending Review in kibana-core [DEPRECATED] via automation Apr 13, 2021
@afharo
Copy link
Member Author

afharo commented Apr 13, 2021

@elasticmachine merge upstream

@afharo afharo added the auto-backport Deprecated: Automatically backport this PR after it's merged label Apr 13, 2021
@afharo afharo enabled auto-merge (squash) April 13, 2021 14:15
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit ff6d1d7 into elastic:master Apr 13, 2021
kibana-core [DEPRECATED] automation moved this from Pending Review to Done (7.13) Apr 13, 2021
@afharo afharo deleted the editorconfig-mdx-support branch April 13, 2021 15:40
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 96942

@afharo afharo mentioned this pull request Apr 14, 2021
Merged
afharo added a commit to afharo/kibana that referenced this pull request Apr 14, 2021
@afharo
.editorconfig MDX files should follow the same rules as MD (elastic…
e30c9f8 
…#96942)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	.editorconfig
@afharo
Copy link
Member Author

afharo commented Apr 14, 2021

Backported in #97079

afharo added a commit that referenced this pull request Apr 14, 2021
@afharo
.editorconfig MDX files should follow the same rules as MD (#96942) (…
1ac31f6 
…#97079)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	.editorconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged docs release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
kibana-core [DEPRECATED]
Done (7.13)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@afharo @kibanamachine @pgayvallet @jbudz