Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Synthetics - add transfer size, resource size, and status to waterfall flyout #97042

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Apr 13, 2021

Fixes #94741

Summary

Add transfer size, resource size, and status to waterfall flyout

Remove Bytes Downloaded (compressed)

Screen Shot 2021-04-13 at 4 39 59 PM

Testing

  • Ensure that resource size is present when using synthetics alpha13

  • Ensure that transfer size is present when using synthetics alpha13

  • Ensure that resource size value is -- when using synthetics < alpha13 (i.e. undefined)

  • Ensure that transfer size value is -- when using synthetics < alpha13 (i.e. undefined)

  • Ensure that status is present

@dominiqueclarke dominiqueclarke added release_note:enhancement enhancement New value added to drive a business result v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 labels Apr 13, 2021
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner April 13, 2021 20:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke added the auto-backport Deprecated: Automatically backport this PR after it's merged label Apr 13, 2021
@dominiqueclarke dominiqueclarke force-pushed the feature/94741-uptime-waterfall-add-status-and-size branch from c4c48dd to 902fcd8 Compare April 14, 2021 12:23
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@dominiqueclarke dominiqueclarke merged commit 1bd951c into elastic:master Apr 15, 2021
@dominiqueclarke dominiqueclarke deleted the feature/94741-uptime-waterfall-add-status-and-size branch April 15, 2021 12:42
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 15, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 15, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 15, 2021
… waterfall flyout (#97042) (#97243)

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 949.9KB 950.5KB +558.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

madirey pushed a commit to madirey/kibana that referenced this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged enhancement New value added to drive a business result release_note:enhancement Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime] Show HTTP Status Code and Compressed/Uncompressed size on waterfall flyout
4 participants