[5.x] add option to confirm overwrite on save #9709
Closed
+151
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #9659 **Commit 1:** add option to confirm overwrite on save * Original sha: 5875c15 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-12-27T14:29:48Z **Commit 2:** Make save options instead of using a boolean to increase readability. * Original sha: 1701b9c * Authored by Stacey Gammon <gammon@elastic.co> on 2016-12-27T21:07:56Z **Commit 3:** clean up comment * Original sha: bc2b9b1 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-12-27T21:14:43Z **Commit 4:** Address code comments - implicit returns from arrow function - throw an error not an object clean up implicit return confusion use promise.reject instead of throw. * Original sha: 8e43346 * Authored by Stacey Gammon <gammon@elastic.co> on 2016-12-29T19:11:50Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add option to confirm overwrite on save
Backports PR #9659
Commit 1:
add option to confirm overwrite on save
Commit 2:
Make save options instead of using a boolean to increase readability.
Commit 3:
clean up comment
Commit 4:
Address code comments
clean up implicit return confusion
use promise.reject instead of throw.