[Form lib] Add documentation #97309
Merged
[Form lib] Add documentation #97309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
documentation
release_note:skip
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
jloleysens
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Man, what a joy to read 😄 ! I was really amazed at how powerful the form lib has become 💪🏻 . Thanks for all the hard work on this documentation @sebelga !
I tested the docs out locally and visited every page and skim read it 👀 and overall looks good to me!
src/plugins/es_ui_shared/static/forms/docs/examples/serializers_deserializers.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
|
Thanks for the review @jloleysens ! I'll wait a few days to see if @elastic/docs-engineering has any comment for this PR 👍 |
goodroot
reviewed
Apr 22, 2021
|
@elasticmachine merge upstream |
|
Thanks for the review @goodroot ! Could you also have a look at the corresponding PR (313) in the docs system? Cheers! |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
madirey
pushed a commit
to madirey/kibana
that referenced
this pull request
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the documentation of the form lib in the new doc system.
This is a follow up of #78654. I have made all the code review suggestion/changes from that PR so hopefully reviewing this PR should be faster.
How to review
You need to have a fork of the new doc system repo on your machine.
As this repo is private, ping me and I will help to set it up. 😊