[ML] Anomaly detection rule lookback interval improvements #97370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e039f25
|
Pinging @elastic/ml-ui (:ml) |
szabosteve
reviewed
Apr 19, 2021
darnautov
commented
Apr 19, 2021
Comment on lines
-344
to
+362
| Math.round( | ||
| resolveBucketSpanInSeconds(jobsResponse.map((v) => v.analysis_config.bucket_span)) * 2 | ||
| ), | ||
| Math.round(maxBucket * 2), |
There was a problem hiding this comment.
Please ignore these changes. Rule executor now utilized fetchResult function.
szabosteve
approved these changes
Apr 19, 2021
14 tasks
droberts195
reviewed
Apr 19, 2021
jgowdyelastic
approved these changes
Apr 19, 2021
| ) { | ||
| return datafeedsResults[0]; | ||
| if (Array.isArray(datafeedsResults)) { | ||
| const result = datafeedsResults.filter((d) => jobIds.includes(d.job_id)); |
There was a problem hiding this comment.
this line could be moved down a few lines so result is only created just before being used.
droberts195
approved these changes
Apr 19, 2021
pheyos
reviewed
Apr 20, 2021
|
thanks for the feedback @pheyos! as we discussed, I'm going to address your comments in a follow-up PR |
darnautov
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 20, 2021
…7370) * [ML] add advanced settings * [ML] default advanced settings * [ML] advanced settings validators * [ML] range control for top n buckets * [ML] execute rule with a new query for most recent anomalies * [ML] find most anomalous bucket from the top N * Revert "[ML] range control for top n buckets" This reverts commit e039f25 * [ML] validate check interval against the lookback interval * [ML] update descriptions * [ML] fix test subjects * [ML] update warning message * [ML] add functional tests * [ML] adjust unit tests, mark getLookbackInterval * [ML] update lookback interval description and warning message * [ML] update fetchResult tsDoc * [ML] cleanup * [ML] fix imports to reduce bundle size * [ML] round up lookback interval * [ML] update functional test assertion * [ML] async import for validator
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 20, 2021
…97595) * [ML] add advanced settings * [ML] default advanced settings * [ML] advanced settings validators * [ML] range control for top n buckets * [ML] execute rule with a new query for most recent anomalies * [ML] find most anomalous bucket from the top N * Revert "[ML] range control for top n buckets" This reverts commit e039f25 * [ML] validate check interval against the lookback interval * [ML] update descriptions * [ML] fix test subjects * [ML] update warning message * [ML] add functional tests * [ML] adjust unit tests, mark getLookbackInterval * [ML] update lookback interval description and warning message * [ML] update fetchResult tsDoc * [ML] cleanup * [ML] fix imports to reduce bundle size * [ML] round up lookback interval * [ML] update functional test assertion * [ML] async import for validator Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
1 task
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/lens/field_stats·ts.apis Lens index stats apis field distribution "before all" hook for "should return a 404 for missing index patterns"Standard OutStack TraceKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/lens/field_stats·ts.apis Lens index stats apis field distribution "after all" hook for "should apply filters and queries"Standard OutStack TraceKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/lens/field_stats·ts.apis Lens index stats apis "after all" hook in "index stats apis"Standard OutStack TraceMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @darnautov |
peteharverson
added
release_note:feature
madirey
pushed a commit
to madirey/kibana
that referenced
this pull request
May 11, 2021
…7370) * [ML] add advanced settings * [ML] default advanced settings * [ML] advanced settings validators * [ML] range control for top n buckets * [ML] execute rule with a new query for most recent anomalies * [ML] find most anomalous bucket from the top N * Revert "[ML] range control for top n buckets" This reverts commit e039f25 * [ML] validate check interval against the lookback interval * [ML] update descriptions * [ML] fix test subjects * [ML] update warning message * [ML] add functional tests * [ML] adjust unit tests, mark getLookbackInterval * [ML] update lookback interval description and warning message * [ML] update fetchResult tsDoc * [ML] cleanup * [ML] fix imports to reduce bundle size * [ML] round up lookback interval * [ML] update functional test assertion * [ML] async import for validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #96381
This PR Improves the lookback interval logic. Instead of a plain time range query for 2x bucket spans the rule executor performs the following:
max(2m, 2 * bucket_span) + query_delay + 1sdate_histogramaggregation with a fixed interval of the bucket span length and descending ordermaxaggregation to retrieve the maximum anomaly score within each bucket of time1by default for bucket spans bigger than 1 minute, or60/bucket_span_in_secfor buckets smaller than 1 minute.As mentioned above, it's possible to override the lookback interval and the number of buckets params by the user in the rule flyout. The warning callout pops up in case the rule check interval is higher than the lookback interval.
Checklist