Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix pagination and sorting on trained models list page #99061

Merged
merged 3 commits into from May 3, 2021
Merged

[ML] Fix pagination and sorting on trained models list page #99061

merged 3 commits into from May 3, 2021

Conversation

darnautov
Copy link
Contributor

Summary

Fixes regression introduced in #92154

  • Put back pagination and sorting logic
  • Fix rendering of boolean values in the expanded row

Checklist

@darnautov darnautov requested review from walterra and qn895 May 3, 2021 15:18
@darnautov darnautov self-assigned this May 3, 2021
@darnautov darnautov requested a review from a team as a code owner May 3, 2021 15:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

walterra
walterra approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also did a local test.

@qn895
Copy link
Member

qn895 commented May 3, 2021

Tested and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +178.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 4da34bb into elastic:master May 3, 2021
@darnautov darnautov deleted the ml-fix-trained-models-list branch May 3, 2021 17:28
@darnautov darnautov mentioned this pull request May 3, 2021
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request May 3, 2021
@darnautov
[ML] Fix pagination and sorting on trained models list page (elastic#…
58fd6cb 
…99061)
@darnautov darnautov mentioned this pull request May 3, 2021
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request May 3, 2021
@darnautov
[ML] Fix pagination and sorting on trained models list page (elastic#…
96e18bd 
…99061)
@darnautov darnautov mentioned this pull request May 3, 2021
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request May 3, 2021
@darnautov
[ML] Fix pagination and sorting on trained models list page (elastic#…
44d6d5e 
…99061)
darnautov added a commit that referenced this pull request May 3, 2021
@darnautov
[ML] Fix pagination and sorting on trained models list page (#99061) (#…
0182b8d 
…99081)
darnautov added a commit that referenced this pull request May 3, 2021
@darnautov
[ML] Fix pagination and sorting on trained models list page (#99061) (#…
9e78f0b 
…99080)
darnautov added a commit that referenced this pull request May 3, 2021
@darnautov
[ML] Fix pagination and sorting on trained models list page (#99061) (#…
fb52647 
…99082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@darnautov darnautov

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:fix v7.12.2 v7.13.0 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@darnautov @elasticmachine @qn895 @kibanamachine @walterra