Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): moving @kbn/plugin-generator into bazel #99646

Merged
merged 3 commits into from
May 11, 2021
Merged

chore(NA): moving @kbn/plugin-generator into bazel #99646

merged 3 commits into from
May 11, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented May 10, 2021

One step forward on #69706

That PR moves the @kbn/plugin-generator into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@mistic mistic mentioned this pull request May 10, 2021
Closed
23 tasks
@mistic mistic added chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0 auto-backport Deprecated: Automatically backport this PR after it's merged labels May 10, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic marked this pull request as ready for review May 10, 2021 19:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic requested a review from jbudz May 10, 2021 19:31
jbudz
jbudz approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows LGTM

@mistic mistic merged commit ada3b42 into elastic:master May 11, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 11, 2021
@mistic @kibanamachine
chore(NA): moving @kbn/plugin-generator into bazel (elastic#99646)
a860de8 
* chore(NA): moving @kbn/plugin-generator into bazel

* chore(NA): add templates to build file

* chore(NA): restore plugins empty file
@kibanamachine kibanamachine mentioned this pull request May 11, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 11, 2021
@kibanamachine @mistic
chore(NA): moving @kbn/plugin-generator into bazel (#99646) (#99854)
a43ea4b 
* chore(NA): moving @kbn/plugin-generator into bazel

* chore(NA): add templates to build file

* chore(NA): restore plugins empty file

Co-authored-by: Tiago Costa <tiagoffcc@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mistic @kibanamachine @elasticmachine @jbudz