Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[packages] Move @kbn/telemetry-tools to Bazel #99726

Merged
merged 3 commits into from
May 12, 2021
Merged

[packages] Move @kbn/telemetry-tools to Bazel #99726

merged 3 commits into from
May 12, 2021

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented May 10, 2021 •
edited by mistic
Loading

Part of #69706

That PR moves the @kbn/telemetry-tools into Bazel by pushing a BUILD file for that package.
After merging this the package will be consumed from within bazel-bin folder.

@jbudz jbudz added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated: Automatically backport this PR after it's merged labels May 10, 2021
@jbudz jbudz requested a review from a team as a code owner May 10, 2021 22:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz requested a review from mistic May 10, 2021 22:19
afharo
afharo approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic mistic mentioned this pull request May 11, 2021
Closed
23 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
licensing 18 15 -3
total -9

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mistic
mistic approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz jbudz merged commit 6759578 into elastic:master May 12, 2021
@jbudz jbudz deleted the bazel/telemetry-tools branch May 12, 2021 14:27
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 12, 2021
@jbudz @kibanamachine
[packages] Move @kbn/telemetry-tools to Bazel (elastic#99726)
28d8cb0
@kibanamachine kibanamachine mentioned this pull request May 12, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 14, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 14, 2021
kibanamachine added a commit that referenced this pull request May 14, 2021
@kibanamachine @jbudz
[packages] Move @kbn/telemetry-tools to Bazel (#99726) (#99929)
500e8d8 
Co-authored-by: Jonathan Budzenski <jon@budzenski.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbudz @elasticmachine @kibanamachine @mistic @afharo