Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto generated update of versioned plugin documentation #530

Merged
merged 1 commit into from Apr 27, 2018
Merged

auto generated update of versioned plugin documentation #530

merged 1 commit into from Apr 27, 2018

Conversation

elasticmachine
Copy link

No description provided.

dedemorton
dedemorton approved these changes Apr 27, 2018
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jsvd Do these PRs still need to be tested, or does the process that generates them do that?

(I did test this one, btw.)

@dedemorton dedemorton merged commit 807a0bf into versioned_plugin_docs Apr 27, 2018
@jsvd
Copy link
Member

jsvd commented Apr 27, 2018

@dedemorton the job runs the doc build: https://github.com/elastic/docs-tools/blob/master/versioned_plugins.rb#L134
Right now prs are created but since it seems things are generated correctly on Monday I'll change this to commit directly to logstash-docs

@jsvd jsvd deleted the versioned_docs_20180427_141412 branch May 5, 2018 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedemorton dedemorton dedemorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@elasticmachine @jsvd @dedemorton