Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
More information about the latest version of bunny can be found here: https://github.com/ruby-amqp/bunny#changes-in-bunny-09
- Loading branch information
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the 0.9.0.pre6 a stable release ?
I know nothing about bunny guys process and habits.
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like 0.9 will be released soon, which we can wait until then to add this commit. In the mean time, I added the 0.9 pre for testing - more information on the 0.8 -> 0.9 change can be found here: https://github.com/ruby-amqp/bunny#changes-in-bunny-09.
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd caution against upgrading dependencies unless we make sure that logstash is compatible. This commit was released in logstash 1.1.10 which broke the amqp inputs and outputs. I'll be fixing logstash to work with the newer bunny which was upgraded in 8d9a3d8 in https://logstash.jira.com/browse/LOGSTASH-1003.
EDIT: That being said, the ideal is to have tests so that upgrading CAN be done like this, but the rabbitmq (formerly amqp) input and outputs don't have sufficient tests.
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies. It looks like there's been quite a bit more activity in https://github.com/logstash/logstash/commits/master/lib/logstash/inputs/rabbitmq.rb that I totally missed when I complained earlier. There are more than a few with rabbitmq which seem to be broken at this point :( Will put as much as I can find in LOGSTASH-1003.
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the first step is to build tests to ensure functionality is kept over time?
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vpernin: see my most recent comment on https://logstash.jira.com/browse/LOGSTASH-1003. we should probably move the entire conversation there.
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies on this, let me know if I can help
4867a89There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mzaccari : no worries, things have to move forwards :) - still unsure if it's a widespread issue or not.